Skip to content

Commit 695b5fe

Browse files
http2: handle write callback gracefully in zombie sessions
1 parent 780ec8a commit 695b5fe

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

test/parallel/test-http2-socket-close-zombie-session.js

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,14 @@ server.listen(0, common.mustCall(() => {
3232
rejectUnauthorized: false
3333
});
3434

35-
let firstRequestDone = false;
35+
// Verify session eventually closes
36+
client.on('close', common.mustCall(() => {
37+
server.close();
38+
}));
3639

3740
// First request to establish connection
3841
const req1 = client.request({ ':path': '/' });
39-
req1.on('response', common.mustCall(() => {
40-
firstRequestDone = true;
41-
}));
42+
req1.on('response', common.mustCall());
4243
req1.on('data', () => {});
4344
req1.on('end', common.mustCall(() => {
4445
// Connection is established, now simulate network black hole
@@ -71,16 +72,10 @@ server.listen(0, common.mustCall(() => {
7172
'Should not receive response from zombie session'
7273
));
7374
req2.end();
74-
} catch (err) {
75+
} catch {
7576
// Also acceptable: synchronous error on request creation
76-
assert(err);
7777
}
7878

79-
// Verify session eventually closes
80-
client.on('close', common.mustCall(() => {
81-
server.close();
82-
}));
83-
8479
// Force cleanup if session doesn't close naturally
8580
setTimeout(() => {
8681
if (!client.destroyed) {

0 commit comments

Comments
 (0)