Skip to content

Commit 73a7a16

Browse files
committed
doc: test and test-only targets do not run linter
`make test` and `make test-only` targets no longer runs linters. This commit updates the inline comments and building doc to reflect reality. Fixes: #58606
1 parent 15bdf38 commit 73a7a16

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

BUILDING.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -402,12 +402,9 @@ If you are running tests before submitting a pull request, use:
402402
```bash
403403
make -j4 test
404404
```
405+
`make -j4 test` does a full check on the codebase, including documentation tests.
405406

406-
`make -j4 test` does a full check on the codebase, including running linters and
407-
documentation tests.
408-
409-
To run the linter without running tests, use
410-
`make lint`/`vcbuild lint`. It will lint JavaScript, C++, and Markdown files.
407+
To run the linter, use `make lint`/`vcbuild lint`. It will lint JavaScript, C++, and Markdown files.
411408

412409
To fix auto fixable JavaScript linting errors, use `make lint-js-fix`.
413410

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ coverage-run-js: ## Run JavaScript tests with coverage.
339339

340340
.PHONY: test
341341
# This does not run tests of third-party libraries inside deps.
342-
test: all ## Run default tests, linters, and build docs.
342+
test: all ## Run default tests and build docs.
343343
$(MAKE) -s tooltest
344344
$(MAKE) -s test-doc
345345
$(MAKE) -s build-addons
@@ -350,7 +350,7 @@ test: all ## Run default tests, linters, and build docs.
350350
$(MAKE) -s jstest
351351

352352
.PHONY: test-only
353-
test-only: all ## Run default tests, without linters or building the docs.
353+
test-only: all ## Run default tests without building the docs.
354354
$(MAKE) build-addons
355355
$(MAKE) build-js-native-api-tests
356356
$(MAKE) build-node-api-tests

0 commit comments

Comments
 (0)