build,win: fix Temporal build

PR-URL: #61806
Fixes: #57127
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Author: StefanStojanovic

configure.py

@@ -1780,6 +1780,14 @@ def configure_node(o):
   o['variables']['target_arch'] = target_arch
   o['variables']['node_byteorder'] = sys.byteorder
 
+  # On Windows, cargo may default to the GNU target (e.g. x86_64-pc-windows-gnu)
+  # but Node.js requires MSVC-compatible libraries. Set explicit Rust target
+  # triple for the target architecture.
+  o['variables']['cargo_rust_target'] = ''
+  if flavor == 'win':
+    o['variables']['cargo_rust_target'] = \
+      'aarch64-pc-windows-msvc' if target_arch == 'arm64' else 'x86_64-pc-windows-msvc'
+
   # Allow overriding the compiler - needed by embedders.
   if options.use_clang:
     o['variables']['clang'] = 1

deps/crates/cargo_build.py

@@ -0,0 +1,60 @@
+#!/usr/bin/env python3
+
+"""Invoke cargo with the correct Rust target on Windows cross-compilation.
+
+Works around three issues: GYP's MSVS generator mangles executable names in
+host-toolset actions (breaking direct cargo calls), GYP cannot set different
+variable values per toolset, and cargo's output directory layout uses Rust
+target triples while MSBuild expects platform names (x64/arm64). This script
+reads MSBuild's $(Platform) to select the right Rust target and copies the
+built library to a path MSBuild can resolve per-project.
+"""
+
+import os
+import shutil
+import subprocess
+import sys
+
+
+def main():
+    # Arguments: <platform> <output_dir> [cargo_args...]
+    if len(sys.argv) < 3:
+        print('Usage: cargo_build.py <platform> <output_dir> [cargo_args...]', file=sys.stderr)
+        sys.exit(1)
+
+    platform = sys.argv[1]     # x64 or arm64
+    output_dir = sys.argv[2]   # SHARED_INTERMEDIATE_DIR
+    cargo_args = sys.argv[3:]
+    build_profile = 'release' if '--release' in cargo_args else 'debug'
+
+    cargo = os.environ.get('CARGO', 'cargo')
+    if not os.path.isabs(cargo) and shutil.which(cargo) is None:
+        home = os.environ.get('USERPROFILE', '')
+        cargo_home = os.path.join(home, '.cargo', 'bin', 'cargo.exe')
+        if os.path.isfile(cargo_home):
+            cargo = cargo_home
+
+    rust_target_map = {
+        'x64': 'x86_64-pc-windows-msvc',
+        'arm64': 'aarch64-pc-windows-msvc',
+    }
+    rust_target = rust_target_map.get(platform)
+    if rust_target is None:
+        print(f'Unsupported platform: {platform}', file=sys.stderr)
+        sys.exit(1)
+
+    cmd = [cargo, 'rustc', '--target', rust_target, '--target-dir', output_dir] + cargo_args
+    ret = subprocess.call(cmd)
+    if ret != 0:
+        sys.exit(ret)
+
+    # Copy output to the platform-specific directory that MSBuild expects.
+    src = os.path.join(output_dir, rust_target, build_profile, 'node_crates.lib')
+    dst_dir = os.path.join(output_dir, platform, build_profile)
+    os.makedirs(dst_dir, exist_ok=True)
+    dst = os.path.join(dst_dir, 'node_crates.lib')
+    shutil.copy2(src, dst)
+
+
+if __name__ == '__main__':
+    main()

deps/crates/crates.gyp

@@ -2,24 +2,46 @@
   'variables': {
     'cargo%': 'cargo',
     'cargo_vendor_dir': './vendor',
+    'cargo_rust_target%': '',
   },
   'conditions': [
     ['build_type == "Release"', {
       'variables': {
         'cargo_build_flags': ['--release'],
-        'node_crates_libpath': '<(SHARED_INTERMEDIATE_DIR)/release/<(STATIC_LIB_PREFIX)node_crates<(STATIC_LIB_SUFFIX)',
       },
+      'conditions': [
+        ['cargo_rust_target!=""', {
+          'variables': {
+            'node_crates_libpath': '<(SHARED_INTERMEDIATE_DIR)/$(Platform)/release/node_crates.lib',
+          },
+        }, {
+          'variables': {
+            'node_crates_libpath': '<(SHARED_INTERMEDIATE_DIR)/release/<(STATIC_LIB_PREFIX)node_crates<(STATIC_LIB_SUFFIX)',
+          },
+        }],
+      ],
     }, {
       'variables': {
         'cargo_build_flags': [],
-        'node_crates_libpath': '<(SHARED_INTERMEDIATE_DIR)/debug/<(STATIC_LIB_PREFIX)node_crates<(STATIC_LIB_SUFFIX)',
       },
+      'conditions': [
+        ['cargo_rust_target!=""', {
+          'variables': {
+            'node_crates_libpath': '<(SHARED_INTERMEDIATE_DIR)/$(Platform)/debug/node_crates.lib',
+          },
+        }, {
+          'variables': {
+            'node_crates_libpath': '<(SHARED_INTERMEDIATE_DIR)/debug/<(STATIC_LIB_PREFIX)node_crates<(STATIC_LIB_SUFFIX)',
+          },
+        }],
+      ],
     }]
   ],
   'targets': [
     {
       'target_name': 'node_crates',
       'type': 'none',
+      'toolsets': ['host', 'target'],
       'hard_dependency': 1,
       'sources': [
         'Cargo.toml',
@@ -39,29 +61,54 @@
           }],
         ],
       },
-      'actions': [
-        {
-          'action_name': 'cargo_build',
-          'inputs': [
-            '<@(_sources)'
-          ],
-          'outputs': [
-            '<(node_crates_libpath)'
+      'conditions': [
+        ['cargo_rust_target!=""', {
+          'actions': [
+            {
+              'action_name': 'cargo_build',
+              'inputs': [
+                '<@(_sources)'
+              ],
+              'outputs': [
+                '<(node_crates_libpath)'
+              ],
+              'action': [
+                '<(python)',
+                'cargo_build.py',
+                '$(Platform)',
+                '<(SHARED_INTERMEDIATE_DIR)',
+                '<@(cargo_build_flags)',
+                '--frozen',
+              ],
+            }
           ],
-          'action': [
-            '<(cargo)',
-            'rustc',
-            '<@(cargo_build_flags)',
-            '--frozen',
-            '--target-dir',
-            '<(SHARED_INTERMEDIATE_DIR)'
+        }, {
+          'actions': [
+            {
+              'action_name': 'cargo_build',
+              'inputs': [
+                '<@(_sources)'
+              ],
+              'outputs': [
+                '<(node_crates_libpath)'
+              ],
+              'action': [
+                '<(cargo)',
+                'rustc',
+                '<@(cargo_build_flags)',
+                '--frozen',
+                '--target-dir',
+                '<(SHARED_INTERMEDIATE_DIR)'
+              ],
+            }
           ],
-        }
+        }],
       ],
     },
     {
       'target_name': 'temporal_capi',
       'type': 'none',
+      'toolsets': ['host', 'target'],
       'sources': [],
       'dependencies': [
         'node_crates',