Skip to content

Commit 85b2a9c

Browse files
committed
fixup! test_runner: cover cancelled subtest order and random seed docs
1 parent 311a65c commit 85b2a9c

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

lib/internal/test_runner/runner.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ const {
9090
countCompletedTest,
9191
kDefaultPattern,
9292
parseCommandLine,
93-
shuffleArrayWithSeed,
9493
} = require('internal/test_runner/utils');
9594
const { Glob } = require('internal/fs/glob');
9695
const { once } = require('events');

test/parallel/test-runner-randomize-first-draw.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import '../common/index.mjs';
12
import assert from 'node:assert';
23
import { test, run } from 'node:test';
34
import * as fixtures from '../common/fixtures.mjs';

test/parallel/test-runner-run.mjs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,19 +106,24 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
106106
files: [fixtures.path('test-runner', 'cancelled-report-order.mjs')],
107107
isolation,
108108
});
109-
const cancelledNames = [];
109+
const cancelledFailures = [];
110110

111111
stream.on('test:fail', ({ name, details }) => {
112112
if (name === 'second' || name === 'third') {
113-
cancelledNames.push(name);
114-
assert.strictEqual(details.error.failureType, 'cancelledByParent');
113+
cancelledFailures.push({
114+
name,
115+
failureType: details.error.failureType,
116+
});
115117
}
116118
});
117119

118120
// eslint-disable-next-line no-unused-vars
119121
for await (const _ of stream);
120122

121-
assert.deepStrictEqual(cancelledNames, ['second', 'third']);
123+
assert.deepStrictEqual(cancelledFailures, [
124+
{ name: 'second', failureType: 'cancelledByParent' },
125+
{ name: 'third', failureType: 'cancelledByParent' },
126+
]);
122127
});
123128
}
124129

0 commit comments

Comments
 (0)