refactor(logger): update enabled checks to use property access for log levels

Author: mertcanaltin

doc/api/logger.md

@@ -278,8 +278,7 @@ added: REPLACEME
 Each log method (`trace`, `debug`, `info`, `warn`, `error`, `fatal`) has an
 `enabled` property that indicates whether that level is enabled for this logger.
 
-This is the recommended way to check if a level is enabled before performing
-expensive computations:
+Use this to check if a level is enabled before performing expensive computations:
 
 ```js
 if (logger.debug.enabled) {
@@ -291,28 +290,12 @@ if (logger.debug.enabled) {
 // logger.debg.enabled → TypeError: Cannot read properties of undefined
 ```
 
-### `logger.enabled(level)`
-
-<!-- YAML
-added: REPLACEME
--->
-
-* `level` {string} The log level to check.
-* Returns: {boolean} `true` if the level is enabled, `false` otherwise.
-
-Checks if a specific log level is enabled for this logger. For most use cases,
-prefer using [`logger.<level>.enabled`][] instead, as it catches typos at
-runtime.
+For dynamic level checks, use property access:
 
 ```js
-// Prefer this:
-if (logger.debug.enabled) {
-  logger.debug('message');
-}
-
-// Over this (typos won't throw):
-if (logger.enabled('debug')) {
-  logger.debug('message');
+const level = config.logLevel; // 'info', 'debug', etc.
+if (logger[level]?.enabled) {
+  logger[level]('Dynamic log message');
 }
 ```
 
@@ -351,32 +334,29 @@ consumer.attach();
 // Consumer now receives all log records at 'info' level and above
 ```
 
-### `consumer.enabled(level)`
+### `consumer.<level>.enabled`
 
 <!-- YAML
 added: REPLACEME
 -->
 
-* `level` {string} The log level to check (e.g., `'debug'`, `'info'`, `'warn'`,
-  `'error'`, `'fatal'`).
-* Returns: {boolean} `true` if the level is enabled, `false` otherwise.
-
-Checks if a specific log level is enabled for this consumer.
+* {boolean} `true` if the level is enabled, `false` otherwise.
 
-This method returns `false` for unknown log levels without throwing an error.
-Log levels are case-sensitive and must be one of the predefined levels:
-`'trace'`, `'debug'`, `'info'`, `'warn'`, `'error'`, `'fatal'`.
+Each log level (`trace`, `debug`, `info`, `warn`, `error`, `fatal`) has an
+`enabled` property that indicates whether that level is enabled for this
+consumer.
 
 ```js
 const { LogConsumer } = require('node:logger');
 
 const consumer = new LogConsumer({ level: 'info' });
 
-console.log(consumer.enabled('debug')); // false (below threshold)
-console.log(consumer.enabled('info'));  // true
-console.log(consumer.enabled('error')); // true
-console.log(consumer.enabled('DEBUG')); // false (unknown level - case sensitive)
-console.log(consumer.enabled('unknown')); // false (unknown level)
+console.log(consumer.debug.enabled); // false (below threshold)
+console.log(consumer.info.enabled);  // true
+console.log(consumer.error.enabled); // true
+
+// Typos will throw a TypeError (safer than silent failure)
+// consumer.debg.enabled → TypeError: Cannot read properties of undefined
 ```
 
 ### `consumer.handle(record)`

lib/logger.js

@@ -93,24 +93,12 @@ class LogConsumer {
     }
   }
 
-  /**
-   * Check if a level would be consumed
-   * @param {string} level
-   * @returns {boolean}
-   */
-  enabled(level) {
-    if (!ObjectHasOwn(LEVELS, level)) {
-      return false;
-    }
-    return LEVELS[level] >= this.#levelValue;
-  }
-
   /**
    * Attach this consumer to log channels
    */
   attach() {
     for (const level of LEVEL_NAMES) {
-      if (this.enabled(level)) {
+      if (this[level].enabled) {
         channels[level].subscribe(this.handle.bind(this));
       }
     }
@@ -363,15 +351,6 @@ class Logger {
     return fn;
   }
 
-  /**
-   * Check if a level would be logged
-   * @param {string} level - Log level to check
-   * @returns {boolean} True if enabled, false otherwise
-   */
-  enabled(level) {
-    return LEVELS[level] >= this.#levelValue;
-  }
-
   /**
    * Create a child logger with additional context
    * @param {object} bindings - Context to add to all child logs

test/parallel/test-log-basic.js

@@ -73,12 +73,12 @@ describe('Logger', () => {
   describe('level filtering', () => {
     it('should filter logs based on configured level', () => {
       const logger = new Logger({ level: 'warn' });
-      assert.strictEqual(logger.enabled('trace'), false);
-      assert.strictEqual(logger.enabled('debug'), false);
-      assert.strictEqual(logger.enabled('info'), false);
-      assert.strictEqual(logger.enabled('warn'), true);
-      assert.strictEqual(logger.enabled('error'), true);
-      assert.strictEqual(logger.enabled('fatal'), true);
+      assert.strictEqual(logger.trace.enabled, false);
+      assert.strictEqual(logger.debug.enabled, false);
+      assert.strictEqual(logger.info.enabled, false);
+      assert.strictEqual(logger.warn.enabled, true);
+      assert.strictEqual(logger.error.enabled, true);
+      assert.strictEqual(logger.fatal.enabled, true);
     });
   });
 
@@ -138,8 +138,8 @@ describe('child logger', () => {
 
       assert(childLogger instanceof Logger);
       assert.notStrictEqual(childLogger, logger);
-      assert.strictEqual(childLogger.enabled('info'), true);
-      assert.strictEqual(childLogger.enabled('debug'), false);
+      assert.strictEqual(childLogger.info.enabled, true);
+      assert.strictEqual(childLogger.debug.enabled, false);
     });
 
     it('should support nested child loggers', () => {
@@ -157,8 +157,8 @@ describe('child logger', () => {
       const logger = new Logger({ level: 'info' });
       const childLogger = logger.child({ requestId: 'abc' }, { level: 'debug' });
 
-      assert.strictEqual(logger.enabled('debug'), false);
-      assert.strictEqual(childLogger.enabled('debug'), true);
+      assert.strictEqual(logger.debug.enabled, false);
+      assert.strictEqual(childLogger.debug.enabled, true);
     });
   });