Skip to content

Commit 8944958

Browse files
committed
fixup! Apply suggestions from code review
1 parent 483c41b commit 8944958

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

doc/contributing/ai-guidelines.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ When using AI as a coding assistant:
2222
* **Understand the codebase first.** Do not skip familiarizing yourself with
2323
the relevant subsystem. LLMs frequently produce inaccurate descriptions of
2424
Node.js internals — always verify against the actual source. When using an AI
25-
tool, ask it to cite the exact source files/PRs/docs it’s relying on, and then
26-
match the claim against that resource to verify if it holds up in the current
25+
tool, ask it to cite the exact source files/PRs/docs it’s relying on, and then
26+
match the claim against that resource to verify if it holds up in the current
2727
code.
2828

2929
* **Own every line you submit.** You are responsible for all code in your
@@ -39,6 +39,10 @@ When using AI as a coding assistant:
3939
be removed or modified without human verification. Do not rely on the LLM
4040
to assess correctness.
4141

42+
* **Do not disappear.** If you open a PR, follow it through. Respond to
43+
feedback and iterate until the work lands or is explicitly closed. If you
44+
can no longer pursue it, close the PR. Stalled PRs block progress.
45+
4246
* **Edit generated comments critically.** LLM-produced comments are often
4347
verbose or inaccurate. Remove comments that simply restate what the code
4448
does; add comments only where the logic is non-obvious.
@@ -47,8 +51,8 @@ When using AI as a coding assistant:
4751

4852
Node.js values concise, precise communication that respects collaborator time.
4953

50-
* **Do not post messages generated entirely by AI** in pull requests, issues, or the
51-
project's communication channels.
54+
* **Do not post messages generated entirely by AI** in pull requests, issues, or the
55+
project's communication channels.
5256
* **Verify accuracy** of any LLM-generated content before including it in a
5357
PR description or comment.
5458
* **Complete pull request templates fully** rather than replacing them with

0 commit comments

Comments
 (0)