http2: fix zombie session crash on socket close

Author: suuuuuuminnnnnn

src/node_http2.cc

@@ -1769,10 +1769,16 @@ void Http2Session::OnStreamAfterWrite(WriteWrap* w, int status) {
   // Guard against write callback being invoked when write is not in progress.
   // This can happen with zombie sessions where the underlying socket is closed
   // but the session hasn't been properly notified. Instead of crashing, we
-  // silently handle the inconsistent state. (Ref: https://github.com/nodejs/node/issues/61304)
+  // terminate the session to prevent resource leaks and further inconsistent
+  // callbacks. (Ref: https://github.com/nodejs/node/issues/61304)
   if (!is_write_in_progress()) {
     Debug(this, "write callback invoked but write not in progress, "
                 "possible zombie session");
+    // Force session termination to clean up resources
+    // Don't attempt to send GOAWAY (socket likely already closed)
+    if (!is_destroyed()) {
+      Close(NGHTTP2_INTERNAL_ERROR, true);
+    }
     return;
   }
   set_write_in_progress(false);

test/parallel/test-http2-socket-close-zombie-session.js

@@ -32,11 +32,27 @@ server.listen(0, common.mustCall(() => {
     rejectUnauthorized: false
   });
 
+  let cleanupTimer;
+  const cleanup = () => {
+    clearTimeout(cleanupTimer);
+    if (!client.destroyed) {
+      client.destroy();
+    }
+    if (server.listening) {
+      server.close();
+    }
+  };
+
   // Verify session eventually closes
   client.on('close', common.mustCall(() => {
-    server.close();
+    cleanup();
   }));
 
+  // Handle errors without failing test
+  client.on('error', () => {
+    // Expected - connection closed
+  });
+
   // First request to establish connection
   const req1 = client.request({ ':path': '/' });
   req1.on('response', common.mustCall());
@@ -76,15 +92,8 @@ server.listen(0, common.mustCall(() => {
         // Also acceptable: synchronous error on request creation
       }
 
-      // Force cleanup if session doesn't close naturally
-      setTimeout(() => {
-        if (!client.destroyed) {
-          client.destroy();
-        }
-        if (server.listening) {
-          server.close();
-        }
-      }, 1000);
+      // Fallback cleanup if close event doesn't fire within 100ms
+      cleanupTimer = setTimeout(cleanup, 100);
     });
   }));