quic: update js impl to use primordials consistently

Author: jasnell

lib/internal/quic/quic.js

@@ -13,6 +13,7 @@ const {
   DataViewPrototypeGetBuffer,
   DataViewPrototypeGetByteLength,
   DataViewPrototypeGetByteOffset,
+  FunctionPrototypeBind,
   ObjectDefineProperties,
   ObjectKeys,
   PromiseWithResolvers,
@@ -597,24 +598,35 @@ function validateBody(body) {
   // With a SharedArrayBuffer, we always copy. We cannot transfer
   // and it's likely unsafe to use the underlying buffer directly.
   if (isSharedArrayBuffer(body)) {
-    return new Uint8Array(body).slice();
+    return TypedArrayPrototypeSlice(new Uint8Array(body));
   }
   if (isArrayBufferView(body)) {
-    const size = body.byteLength;
-    const offset = body.byteOffset;
+    let size, offset, buffer;
+    if (isDataView(body)) {
+      size = DataViewPrototypeGetByteLength(body);
+      offset = DataViewPrototypeGetByteOffset(body);
+      buffer = DataViewPrototypeGetBuffer(body);
+    } else {
+      size = TypedArrayPrototypeGetByteLength(body);
+      offset = TypedArrayPrototypeGetByteOffset(body);
+      buffer = TypedArrayPrototypeGetBuffer(body);
+    }
     // We have to be careful in this case. If the ArrayBufferView is a
     // subset of the underlying ArrayBuffer, transferring the entire
     // ArrayBuffer could be incorrect if other views are also using it.
     // So if offset > 0 or size != buffer.byteLength, we'll copy the
     // subset into a new ArrayBuffer instead of transferring.
-    if (isSharedArrayBuffer(body.buffer) ||
-        offset !== 0 || size !== body.buffer.byteLength) {
-      return new Uint8Array(body, offset, size).slice();
+    if (isSharedArrayBuffer(buffer) ||
+        offset !== 0 ||
+        size !== ArrayBufferPrototypeGetByteLength(buffer)) {
+      return TypedArrayPrototypeSlice(
+        new Uint8Array(buffer, offset, size));
     }
     // It's still possible that the ArrayBuffer is being used elsewhere,
     // but we really have no way of knowing. We'll just have to trust
     // the caller in this case.
-    return new Uint8Array(ArrayBufferPrototypeTransfer(body.buffer), offset, size);
+    return new Uint8Array(
+      ArrayBufferPrototypeTransfer(buffer), offset, size);
   }
   if (isBlob(body)) return body[kBlobHandle];
 
@@ -763,7 +775,7 @@ class QuicStream {
       this.#state.wantsBlock = false;
     } else {
       validateFunction(fn, 'onblocked');
-      this.#onblocked = fn.bind(this);
+      this.#onblocked = FunctionPrototypeBind(fn, this);
       this.#state.wantsBlock = true;
     }
   }
@@ -781,7 +793,7 @@ class QuicStream {
       this.#state.wantsReset = false;
     } else {
       validateFunction(fn, 'onreset');
-      this.#onreset = fn.bind(this);
+      this.#onreset = FunctionPrototypeBind(fn, this);
       this.#state.wantsReset = true;
     }
   }
@@ -803,7 +815,7 @@ class QuicStream {
           'The negotiated QUIC application protocol does not support headers');
       }
       validateFunction(fn, 'onheaders');
-      this.#onheaders = fn.bind(this);
+      this.#onheaders = FunctionPrototypeBind(fn, this);
       this.#state[kWantsHeaders] = true;
     }
   }
@@ -825,7 +837,7 @@ class QuicStream {
           'The negotiated QUIC application protocol does not support headers');
       }
       validateFunction(fn, 'ontrailers');
-      this.#ontrailers = fn.bind(this);
+      this.#ontrailers = FunctionPrototypeBind(fn, this);
       this.#state[kWantsTrailers] = true;
     }
   }
@@ -846,7 +858,7 @@ class QuicStream {
           'The negotiated QUIC application protocol does not support headers');
       }
       validateFunction(fn, 'onwanttrailers');
-      this.#onwanttrailers = fn.bind(this);
+      this.#onwanttrailers = FunctionPrototypeBind(fn, this);
     }
   }
 
@@ -1339,7 +1351,7 @@ class QuicSession {
       this.#onstream = undefined;
     } else {
       validateFunction(fn, 'onstream');
-      this.#onstream = fn.bind(this);
+      this.#onstream = FunctionPrototypeBind(fn, this);
     }
   }
 
@@ -1356,7 +1368,7 @@ class QuicSession {
       this.#state.hasDatagramListener = false;
     } else {
       validateFunction(fn, 'ondatagram');
-      this.#ondatagram = fn.bind(this);
+      this.#ondatagram = FunctionPrototypeBind(fn, this);
       this.#state.hasDatagramListener = true;
     }
   }
@@ -1378,7 +1390,7 @@ class QuicSession {
       this.#state.hasDatagramStatusListener = false;
     } else {
       validateFunction(fn, 'ondatagramstatus');
-      this.#ondatagramstatus = fn.bind(this);
+      this.#ondatagramstatus = FunctionPrototypeBind(fn, this);
       this.#state.hasDatagramStatusListener = true;
     }
   }
@@ -1396,7 +1408,7 @@ class QuicSession {
       this.#state.hasPathValidationListener = false;
     } else {
       validateFunction(fn, 'onpathvalidation');
-      this.#onpathvalidation = fn.bind(this);
+      this.#onpathvalidation = FunctionPrototypeBind(fn, this);
       this.#state.hasPathValidationListener = true;
     }
   }
@@ -1414,7 +1426,7 @@ class QuicSession {
       this.#state.hasSessionTicketListener = false;
     } else {
       validateFunction(fn, 'onsessionticket');
-      this.#onsessionticket = fn.bind(this);
+      this.#onsessionticket = FunctionPrototypeBind(fn, this);
       this.#state.hasSessionTicketListener = true;
     }
   }
@@ -1431,7 +1443,7 @@ class QuicSession {
       this.#onversionnegotiation = undefined;
     } else {
       validateFunction(fn, 'onversionnegotiation');
-      this.#onversionnegotiation = fn.bind(this);
+      this.#onversionnegotiation = FunctionPrototypeBind(fn, this);
     }
   }
 
@@ -1447,7 +1459,7 @@ class QuicSession {
       this.#onhandshake = undefined;
     } else {
       validateFunction(fn, 'onhandshake');
-      this.#onhandshake = fn.bind(this);
+      this.#onhandshake = FunctionPrototypeBind(fn, this);
     }
   }
 
@@ -1464,7 +1476,7 @@ class QuicSession {
       this.#state.hasNewTokenListener = false;
     } else {
       validateFunction(fn, 'onnewtoken');
-      this.#onnewtoken = fn.bind(this);
+      this.#onnewtoken = FunctionPrototypeBind(fn, this);
       this.#state.hasNewTokenListener = true;
     }
   }
@@ -1482,7 +1494,7 @@ class QuicSession {
       this.#state.hasOriginListener = false;
     } else {
       validateFunction(fn, 'onorigin');
-      this.#onorigin = fn.bind(this);
+      this.#onorigin = FunctionPrototypeBind(fn, this);
       this.#state.hasOriginListener = true;
     }
   }
@@ -2450,7 +2462,7 @@ class QuicEndpoint {
       throw new ERR_INVALID_STATE('Endpoint is already listening');
     }
     validateObject(options, 'options');
-    this.#onsession = onsession.bind(this);
+    this.#onsession = FunctionPrototypeBind(onsession, this);
 
     const {
       onstream,