cli: add --experimental flag

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

Author: ShogunPanda

doc/api/cli.md

@@ -1033,6 +1033,16 @@ and `"` are usable.
 It is possible to run code containing inline types unless the
 [`--no-strip-types`][] flag is provided.
 
+### `--experimental`
+
+<!-- YAML
+added:
+  - REPLACEME
+-->
+
+Enable all command-line experimental features that are otherwise gated behind
+individual `--experimental-*` flags.
+
 ### `--experimental-addon-modules`
 
 <!-- YAML
@@ -3700,6 +3710,7 @@ one is included in the list below.
 * `--experimental-top-level-await`
 * `--experimental-vm-modules`
 * `--experimental-wasi-unstable-preview1`
+* `--experimental`
 * `--force-context-aware`
 * `--force-fips`
 * `--force-node-api-uncaught-exceptions-policy`

doc/node.1

@@ -620,6 +620,10 @@ and \fB"\fR are usable.
 It is possible to run code containing inline types unless the
 \fB--no-strip-types\fR flag is provided.
 .
+.It Fl -experimental
+Enable all command-line experimental features that are otherwise gated behind
+individual \fB--experimental-*\fR flags.
+.
 .It Fl -experimental-addon-modules
 Enable experimental import support for \fB.node\fR addons.
 .
@@ -1899,6 +1903,8 @@ one is included in the list below.
 .It
 \fB--entry-url\fR
 .It
+\fB--experimental\fR
+.It
 \fB--experimental-abortcontroller\fR
 .It
 \fB--experimental-addon-modules\fR

lib/internal/options.js

@@ -7,6 +7,7 @@ const {
   ObjectFromEntries,
   ObjectKeys,
   StringPrototypeReplace,
+  StringPrototypeStartsWith,
 } = primordials;
 
 const {
@@ -148,7 +149,14 @@ function refreshOptions() {
 }
 
 function getOptionValue(optionName) {
-  return getCLIOptionsFromBinding()[optionName];
+  const options = getCLIOptionsFromBinding();
+  let value = options[optionName];
+
+  if (!value && StringPrototypeStartsWith(optionName, '--experimental-') && options['--experimental']) {
+    value = options['--experimental'];
+  }
+
+  return value;
 }
 
 function getAllowUnauthorized() {

src/api/environment.cc

@@ -268,14 +268,16 @@ void SetIsolateMiscHandlers(v8::Isolate* isolate, const IsolateSettings& s) {
       modify_code_generation_from_strings_callback);
 
   Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
-  if (per_process::cli_options->get_per_isolate_options()
-          ->get_per_env_options()
-          ->experimental_fetch) {
+  EnvironmentOptions* options =
+      per_process::cli_options->get_per_isolate_options()
+          ->get_per_env_options();
+  if (options->experimental_fetch || options->experimental) {
     isolate->SetWasmStreamingCallback(wasm_web_api::StartStreamingCompilation);
   }
 
   if (per_process::cli_options->get_per_isolate_options()
-          ->experimental_shadow_realm) {
+          ->experimental_shadow_realm ||
+      options->experimental) {
     isolate->SetHostCreateShadowRealmContextCallback(
         shadow_realm::HostCreateShadowRealmContextCallback);
   }

src/inspector/network_agent.cc

@@ -404,11 +404,12 @@ protocol::DispatchResponse NetworkAgent::loadNetworkResource(
     const protocol::String& in_url,
     std::unique_ptr<protocol::Network::LoadNetworkResourcePageResult>*
         out_resource) {
-  if (!env_->options()->experimental_inspector_network_resource) {
+  if (!env_->options()->experimental_inspector_network_resource &&
+      !env_->options()->experimental) {
     return protocol::DispatchResponse::ServerError(
         "Network resource loading is not enabled. This feature is "
         "experimental and requires --experimental-inspector-network-resource "
-        "flag to be set.");
+        "or --experimental flag to be set.");
   }
   CHECK_NOT_NULL(network_resource_manager_);
   std::string data = network_resource_manager_->Get(in_url);

src/inspector_agent.cc

@@ -247,7 +247,8 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel,
     }
     runtime_agent_ = std::make_unique<protocol::RuntimeAgent>();
     runtime_agent_->Wire(node_dispatcher_.get());
-    if (env->options()->experimental_inspector_network_resource) {
+    if (env->options()->experimental_inspector_network_resource ||
+        env->options()->experimental) {
       io_agent_ = std::make_unique<protocol::IoAgent>(
           env->inspector_agent()->GetNetworkResourceManager());
       io_agent_->Wire(node_dispatcher_.get());
@@ -260,12 +261,14 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel,
           std::make_unique<NetworkInspector>(env, inspector.get(), nullptr);
     }
     network_inspector_->Wire(node_dispatcher_.get());
-    if (env->options()->experimental_worker_inspection) {
+    if (env->options()->experimental_worker_inspection ||
+        env->options()->experimental) {
       target_agent_ = std::make_shared<protocol::TargetAgent>();
       target_agent_->Wire(node_dispatcher_.get());
       target_agent_->listenWorker(worker_manager);
     }
-    if (env->options()->experimental_storage_inspection) {
+    if (env->options()->experimental_storage_inspection ||
+        env->options()->experimental) {
       dom_storage_agent_ = std::make_unique<DOMStorageAgent>(env);
       dom_storage_agent_->Wire(node_dispatcher_.get());
       storage_agent_ = std::make_unique<protocol::StorageAgent>(env_);
@@ -304,11 +307,13 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel,
     std::string domain_name = raw_event.substr(0, raw_event.find('.'));
     std::string event_name = raw_event.substr(raw_event.find('.') + 1);
     if (network_inspector_->canEmit(domain_name) &&
-        env_->options()->experimental_network_inspection) {
+        (env_->options()->experimental_network_inspection ||
+         env_->options()->experimental)) {
       network_inspector_->emitNotification(
           context, domain_name, event_name, params);
     } else if (dom_storage_agent_ && dom_storage_agent_->canEmit(domain_name) &&
-               env_->options()->experimental_storage_inspection) {
+               (env_->options()->experimental_storage_inspection ||
+                env_->options()->experimental)) {
       dom_storage_agent_->emitNotification(context, event_name, params);
     }
   }

src/node_options.cc

@@ -581,6 +581,10 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
             "experimental import support for addons",
             &EnvironmentOptions::experimental_addon_modules,
             kAllowedInEnvvar);
+  AddOption("--experimental",
+            "",
+            &EnvironmentOptions::experimental,
+            kAllowedInEnvvar);
   AddOption("--experimental-abortcontroller", "", NoOp{}, kAllowedInEnvvar);
   AddOption("--experimental-eventsource",
             "experimental EventSource API",

src/node_options.h

@@ -122,6 +122,7 @@ class EnvironmentOptions : public Options {
   bool require_module = true;
   std::string dns_result_order;
   bool enable_source_maps = false;
+  bool experimental = false;
   bool experimental_addon_modules = false;
   bool experimental_eventsource = false;
   bool experimental_fetch = true;

test/parallel/test-experimental-flag.js

@@ -0,0 +1,13 @@
+// Flags: --experimental
+'use strict';
+
+// This test replicates the test in test/parallel/test-eventsource.js,
+// but with the --experimental flag enabled instead of --experimental-eventsource.
+// This tests that the experimental flag implicitly enables the eventsource experimental feature.
+// When eventsource is no longer experimental, this test should be updated to pick a
+// different experimental feature to test against.
+
+require('../common');
+const assert = require('assert');
+
+assert.strictEqual(typeof EventSource, 'function');