url: align default argument handling for URLPattern with webidl

Author: panva

src/node_url_pattern.cc

@@ -202,7 +202,10 @@ void URLPattern::New(const FunctionCallbackInfo<Value>& args) {
   // - new URLPattern(input, baseURL)
   // - new URLPattern(input, options)
   // - new URLPattern(input, baseURL, options)
-  if (args[0]->IsString()) {
+  // Per WebIDL, undefined for an optional argument uses the default value.
+  if (args[0]->IsUndefined()) {
+    init = ada::url_pattern_init{};
+  } else if (args[0]->IsString()) {
     BufferValue input_buffer(env->isolate(), args[0]);
     CHECK_NOT_NULL(*input_buffer);
     input = input_buffer.ToString();
@@ -218,7 +221,7 @@ void URLPattern::New(const FunctionCallbackInfo<Value>& args) {
   }
 
   // The next argument can be baseURL or options.
-  if (args.Length() > 1) {
+  if (args.Length() > 1 && !args[1]->IsUndefined()) {
     if (args[1]->IsString()) {
       BufferValue base_url_buffer(env->isolate(), args[1]);
       CHECK_NOT_NULL(*base_url_buffer);
@@ -239,7 +242,7 @@ void URLPattern::New(const FunctionCallbackInfo<Value>& args) {
     }
 
     // Only remaining argument can be options.
-    if (args.Length() > 2) {
+    if (args.Length() > 2 && !args[2]->IsUndefined()) {
       if (!args[2]->IsObject()) {
         THROW_ERR_INVALID_ARG_TYPE(env, "options must be an object");
         return;
@@ -564,7 +567,7 @@ void URLPattern::Exec(const FunctionCallbackInfo<Value>& args) {
   ada::url_pattern_input input;
   std::optional<std::string> baseURL{};
   std::string input_base;
-  if (args.Length() == 0) {
+  if (args.Length() == 0 || args[0]->IsUndefined()) {
     input = ada::url_pattern_init{};
   } else if (args[0]->IsString()) {
     Utf8Value input_value(env->isolate(), args[0].As<String>());
@@ -580,7 +583,7 @@ void URLPattern::Exec(const FunctionCallbackInfo<Value>& args) {
     return;
   }
 
-  if (args.Length() > 1) {
+  if (args.Length() > 1 && !args[1]->IsUndefined()) {
     if (!args[1]->IsString()) {
       THROW_ERR_INVALID_ARG_TYPE(env, "baseURL must be a string");
       return;
@@ -607,7 +610,7 @@ void URLPattern::Test(const FunctionCallbackInfo<Value>& args) {
   ada::url_pattern_input input;
   std::optional<std::string> baseURL{};
   std::string input_base;
-  if (args.Length() == 0) {
+  if (args.Length() == 0 || args[0]->IsUndefined()) {
     input = ada::url_pattern_init{};
   } else if (args[0]->IsString()) {
     Utf8Value input_value(env->isolate(), args[0].As<String>());
@@ -623,7 +626,7 @@ void URLPattern::Test(const FunctionCallbackInfo<Value>& args) {
     return;
   }
 
-  if (args.Length() > 1) {
+  if (args.Length() > 1 && !args[1]->IsUndefined()) {
     if (!args[1]->IsString()) {
       THROW_ERR_INVALID_ARG_TYPE(env, "baseURL must be a string");
       return;

test/parallel/test-urlpattern-types.js

@@ -44,3 +44,49 @@ assert.throws(() => pattern.test(1), {
 assert.throws(() => pattern.test('', 1), {
   code: 'ERR_INVALID_ARG_TYPE',
 });
+
+// Per WebIDL, undefined for optional arguments with defaults should use the
+// default value (empty URLPatternInit {}) rather than throwing.
+
+// Constructor: undefined input should be treated as empty init.
+{
+  const p = new URLPattern(undefined);
+  assert.strictEqual(p.protocol, '*');
+  assert.strictEqual(p.hostname, '*');
+}
+
+// Constructor: undefined input with undefined baseURL.
+{
+  const p = new URLPattern(undefined, undefined);
+  assert.strictEqual(p.protocol, '*');
+  assert.strictEqual(p.pathname, '*');
+}
+
+// Constructor: valid input with undefined options.
+{
+  const p = new URLPattern({ pathname: '/foo' }, undefined);
+  assert.strictEqual(p.pathname, '/foo');
+}
+
+// Constructor: string input, undefined baseURL, undefined options.
+{
+  const p = new URLPattern('https://example.com/foo', undefined, undefined);
+  assert.strictEqual(p.hostname, 'example.com');
+  assert.strictEqual(p.pathname, '/foo');
+}
+
+// exec() and test(): undefined input should be treated as empty init.
+{
+  const p = new URLPattern();
+  assert.strictEqual(p.test(undefined), true);
+  assert.strictEqual(p.test(undefined, undefined), true);
+  assert.notStrictEqual(p.exec(undefined), null);
+  assert.notStrictEqual(p.exec(undefined, undefined), null);
+}
+
+// exec() and test(): valid input with undefined baseURL.
+{
+  const p = new URLPattern({ protocol: 'https' });
+  assert.strictEqual(p.test('https://example.com', undefined), true);
+  assert.notStrictEqual(p.exec('https://example.com', undefined), null);
+}