Skip to content

Commit c02bee3

Browse files
committed
meta: require DCO signoff in commit message guidelines
Apply suggestion from @jasnell PR-URL: #62510 Refs: nodejs/core-validate-commit#141 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent e419afd commit c02bee3

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

doc/contributing/pull-requests.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,14 @@ A good commit message should describe what changed and why.
199199
contain an explanation about the reason of the breaking change, which
200200
situation would trigger the breaking change, and what is the exact change.
201201

202+
6. Your commit must contain the `Signed-off-by` line with your name and email
203+
address as an acknowledgement that you agree to the [Developer Certificate of Origin][].
204+
Bot generated commits are exempt from this requirement. If a commit has
205+
multiple authors, the `Signed-off-by` line should be added for each author;
206+
and at least one should match the author information in the commit metadata.
207+
This rule does not apply to dependency updates (e.g. cherry-picks), release
208+
commits, or backport commits.
209+
202210
Sample complete commit message:
203211

204212
```text
@@ -210,6 +218,7 @@ less.
210218
211219
Fixes: https://github.com/nodejs/node/issues/1337
212220
Refs: https://eslint.org/docs/rules/space-in-parens.html
221+
Signed-off-by: J. Random User <j.random.user@example.com>
213222
```
214223

215224
If you are new to contributing to Node.js, please try to do your best at
@@ -594,6 +603,7 @@ More than one subsystem may be valid for any particular issue or pull request.
594603
[Building guide]: ../../BUILDING.md
595604
[CI (Continuous Integration) test run]: #continuous-integration-testing
596605
[Code of Conduct]: https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
606+
[Developer Certificate of Origin]: ../../CONTRIBUTING.md#developers-certificate-of-origin-11
597607
[Onboarding guide]: ../../onboarding.md
598608
[approved]: #getting-approvals-for-your-pull-request
599609
[benchmark results]: writing-and-running-benchmarks.md

0 commit comments

Comments
 (0)