Commit c592499
committed
build: remove duplicate C++ standard flags from LIEF
LIEF's lief.gyp explicitly sets -std=gnu++17 in cflags_cc and
xcode_settings, while common.gypi already sets -std=gnu++20
project-wide. This results in both flags being passed to the compiler
(-std=gnu++20 -std=gnu++17). Since the last flag wins, LIEF was
silently compiling as C++17 instead of the intended project-wide C++20.
Remove the explicit -std=gnu++17 flags from cflags_cc and
xcode_settings.OTHER_CPLUSPLUSFLAGS, and the msvs_settings
LanguageStandard override (stdcpp17), so LIEF uses the project-wide
C++20 standard. LIEF is compatible with C++20 because
SPDLOG_USE_STD_FORMAT is not defined, so spdlog uses its bundled fmt
library rather than std::format, avoiding any C++20 conflicts.
Note: a separate issue with a stray debug string in the defines list
is addressed in a follow-up PR.
Fixes: #621291 parent 9f0a3e6 commit c592499
1 file changed
+0
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
454 | 454 | | |
455 | 455 | | |
456 | 456 | | |
457 | | - | |
458 | | - | |
459 | | - | |
460 | | - | |
461 | | - | |
462 | | - | |
463 | 457 | | |
464 | | - | |
465 | 458 | | |
466 | 459 | | |
467 | 460 | | |
| |||
474 | 467 | | |
475 | 468 | | |
476 | 469 | | |
477 | | - | |
478 | 470 | | |
479 | 471 | | |
480 | 472 | | |
| |||
0 commit comments