node-api: minimal C node_embedding_api function

Co-authored-by: vmoroz <vmorozov@microsoft.com>

Author: alshdavid

doc/api/embedding.md

@@ -167,6 +167,47 @@ int RunNodeInstance(MultiIsolatePlatform* platform,
 }
 ```
 
+## C runtime API
+
+<!--introduced_in=REPLACEME-->
+
+While Node.js provides an extensive C++ embedding API that can be used from C++
+applications, the C-based API is useful when Node.js is embedded as a shared
+libnode library into C++ or non-C++ applications.
+
+### API design overview
+
+One of the goals for the C based runtime API is to be ABI stable. It means that
+applications must be able to use newer libnode versions without recompilation.
+The following design principles are targeting to achieve that goal.
+
+* Follow the best practices for the [node-api][] design and build on top of
+  the [node-api][].
+
+### API reference
+
+#### Functions
+
+##### `node_embed_start`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+> Stability: 1 - Experimental
+
+Runs Node.js runtime instance the same way as the Node.js executable.
+
+```c
+int32_t NAPI_CDECL node_embed_start(
+  int32_t argc,
+  char* argv[]);
+```
+
+* `[in] argc`: Number of items in the `argv` array.
+* `[in] argv`: CLI arguments as an array of zero terminated strings.
+  Returns `int32_t` with runtime instance exit code.
+
 [CLI options]: cli.md
 [`process.memoryUsage()`]: process.md#processmemoryusage
 [deprecation policy]: deprecations.md

node.gyp

@@ -121,6 +121,7 @@
       'src/node_debug.cc',
       'src/node_dir.cc',
       'src/node_dotenv.cc',
+      'src/node_embed_api.cc',
       'src/node_env_var.cc',
       'src/node_errors.cc',
       'src/node_external_reference.cc',
@@ -241,6 +242,7 @@
       'src/module_wrap.h',
       'src/node.h',
       'src/node_api.h',
+      'src/node_api_internals.h',
       'src/node_api_types.h',
       'src/node_binding.h',
       'src/node_blob.h',
@@ -253,6 +255,7 @@
       'src/node_debug.h',
       'src/node_dir.h',
       'src/node_dotenv.h',
+      'src/node_embed_api.h',
       'src/node_errors.h',
       'src/node_exit_code.h',
       'src/node_external_reference.h',
@@ -895,6 +898,7 @@
         '<(SHARED_INTERMEDIATE_DIR)' # for node_natives.h
       ],
       'dependencies': [
+        'tools/v8_gypfiles/abseil.gyp:abseil',
         'node_js2c#host',
       ],
 
@@ -955,9 +959,6 @@
             'src/node_snapshot_stub.cc',
           ]
         }],
-        [ 'node_use_bundled_v8!="false"', {
-          'dependencies': [ 'tools/v8_gypfiles/abseil.gyp:abseil' ],
-        }],
         [ 'node_shared_gtest=="false"', {
           'dependencies': [
             'deps/googletest/googletest.gyp:gtest_prod',
@@ -1278,6 +1279,7 @@
 
       'dependencies': [
         '<(node_lib_target_name)',
+        'tools/v8_gypfiles/abseil.gyp:abseil',
       ],
 
       'includes': [
@@ -1311,9 +1313,6 @@
         [ 'node_shared_gtest=="true"', {
           'libraries': [ '-lgtest_main' ],
         }],
-        [ 'node_use_bundled_v8!="false"', {
-          'dependencies': [ 'tools/v8_gypfiles/abseil.gyp:abseil' ],
-        }],
         [ 'node_shared_hdr_histogram=="false"', {
           'dependencies': [
             'deps/histogram/histogram.gyp:histogram',
@@ -1410,6 +1409,8 @@
       'sources': [
         'src/node_snapshot_stub.cc',
         'test/embedding/embedtest.cc',
+        'test/embedding/embedtest_c_api_main.c',
+        'test/embedding/embedtest_main.cc',
       ],
 
       'conditions': [
@@ -1552,7 +1553,7 @@
         [ 'OS=="mac"', {
           'libraries': [ '-framework CoreFoundation -framework Security' ],
         }],
-        [ 'node_shared_simdutf=="false" and node_use_bundled_v8!="false"', {
+        [ 'node_shared_simdutf=="false"', {
           'dependencies': [ 'tools/v8_gypfiles/v8.gyp:simdutf#host' ],
         }],
         [ 'node_shared_libuv=="false"', {

src/node_embed_api.cc

@@ -0,0 +1,25 @@
+//
+// Description: C-based API for embedding Node.js.
+//
+// !!! WARNING !!! WARNING !!! WARNING !!!
+// This is a new API and is subject to change.
+// While it is C-based, it is not ABI safe yet.
+// Consider all functions and data structures as experimental.
+// !!! WARNING !!! WARNING !!! WARNING !!!
+//
+// This file contains the C-based API for embedding Node.js in a host
+// application. The API is designed to be used by applications that want to
+// embed Node.js as a shared library (.so or .dll) and can interop with
+// C-based API.
+//
+
+#include "node_embed_api.h"
+#include "node.h"
+
+EXTERN_C_START
+
+int32_t NAPI_CDECL node_embed_start(int32_t argc, char* argv[]) {
+  return node::Start(argc, argv);
+}
+
+EXTERN_C_END

src/node_embed_api.h

@@ -0,0 +1,28 @@
+//
+// Description: C-based API for embedding Node.js.
+//
+// !!! WARNING !!! WARNING !!! WARNING !!!
+// This is a new API and is subject to change.
+// While it is C-based, it is not ABI safe yet.
+// Consider all functions and data structures as experimental.
+// !!! WARNING !!! WARNING !!! WARNING !!!
+//
+// This file contains the C-based API for embedding Node.js in a host
+// application. The API is designed to be used by applications that want to
+// embed Node.js as a shared library (.so or .dll) and can interop with
+// C-based API.
+//
+
+#ifndef SRC_NODE_EMBED_API_H_
+#define SRC_NODE_EMBED_API_H_
+
+#include "node_api.h"
+
+EXTERN_C_START
+
+// Runs Node.js start function. It is the same as running Node.js from CLI.
+NAPI_EXTERN int32_t NAPI_CDECL node_embed_start(int32_t argc, char* argv[]);
+
+EXTERN_C_END
+
+#endif  // SRC_NODE_EMBED_API_H_

test/embedding/embedtest.cc

@@ -3,8 +3,8 @@
 #endif
 #include <assert.h>
 #include "cppgc/platform.h"
-#include "executable_wrapper.h"
 #include "node.h"
+#include "uv.h"
 
 #include <algorithm>
 
@@ -28,10 +28,7 @@ static int RunNodeInstance(MultiIsolatePlatform* platform,
                            const std::vector<std::string>& args,
                            const std::vector<std::string>& exec_args);
 
-NODE_MAIN(int argc, node::argv_type raw_argv[]) {
-  char** argv = nullptr;
-  node::FixupMain(argc, raw_argv, &argv);
-
+int32_t test_main_cpp_api(int32_t argc, char* argv[]) {
   std::vector<std::string> args(argv, argv + argc);
   std::shared_ptr<node::InitializationResult> result =
       node::InitializeOncePerProcess(

test/embedding/embedtest_c_api_main.c

@@ -0,0 +1,8 @@
+#include "node_embed_api.h"
+
+// The simplest Node.js embedding scenario where the Node.js start function is
+// invoked from the libnode shared library as it would be run from the Node.js
+// CLI.
+int32_t test_main_c_api_nodejs_main(int32_t argc, char* argv[]) {
+  return node_embed_start(argc, argv);
+}

test/embedding/embedtest_main.cc

@@ -0,0 +1,37 @@
+#include <cstring>
+#include <string_view>
+#include <unordered_map>
+#include "executable_wrapper.h"
+
+int32_t test_main_cpp_api(int32_t argc, char* argv[]);
+
+extern "C" int32_t test_main_c_api_nodejs_main(int32_t argc, char* argv[]);
+
+using MainCallback = int32_t (*)(int32_t argc, char* argv[]);
+
+int32_t CallWithoutArg1(MainCallback main, int32_t argc, char* argv[]) {
+  for (int32_t i = 2; i < argc; i++) {
+    argv[i - 1] = argv[i];
+  }
+  argv[--argc] = nullptr;
+  return main(argc, argv);
+}
+
+NODE_MAIN(int32_t argc, node::argv_type raw_argv[]) {
+  char** argv = nullptr;
+  node::FixupMain(argc, raw_argv, &argv);
+
+  const std::unordered_map<std::string_view, MainCallback> main_map = {
+      {"cpp-api", test_main_cpp_api},
+      {"c-api-nodejs-main", test_main_c_api_nodejs_main},
+  };
+  if (argc > 1) {
+    char* arg1 = argv[1];
+    for (const auto& [key, value] : main_map) {
+      if (key == arg1) {
+        return CallWithoutArg1(value, argc, argv);
+      }
+    }
+  }
+  return test_main_cpp_api(argc, argv);
+}

test/embedding/test-embedding-c-api-start.js

@@ -0,0 +1,15 @@
+'use strict';
+
+// Tests that we can run the C-API node_embed_start.
+
+const common = require('../common');
+const { spawnSyncAndAssert } = require('../common/child_process');
+
+spawnSyncAndAssert(
+  common.resolveBuiltBinary('embedtest'),
+  ['c-api-nodejs-main', '--eval', 'console.log("Hello World")'],
+  {
+    trim: true,
+    stdout: 'Hello World',
+  },
+);