Skip to content

Commit cd98ac9

Browse files
committed
test: fix flaky https tests on windows
The test-https-server-options-incoming-message and test-https-server-options-server-response tests can be flaky on Windows. Opencode/Opus helped figure out why.
1 parent e78ccd8 commit cd98ac9

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

test/parallel/test-https-server-options-incoming-message.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ server.on('listening', common.mustCall(function makeRequest() {
4444
}, common.mustCall((res) => {
4545
assert.strictEqual(res.statusCode, 200);
4646
res.on('end', () => {
47+
server.closeAllConnections();
4748
server.close();
4849
});
4950
res.resume();

test/parallel/test-https-server-options-server-response.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ server.on('listening', common.mustCall(function makeRequest() {
4040
}, common.mustCall((res) => {
4141
assert.strictEqual(res.statusCode, 200);
4242
res.on('end', () => {
43+
server.closeAllConnections();
4344
server.close();
4445
});
4546
res.resume();

0 commit comments

Comments
 (0)