Skip to content

Commit d155db3

Browse files
committed
test: skip test-temporal-with-zoneinfo on system-icu builds
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent ed05549 commit d155db3

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

configure.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2388,6 +2388,7 @@ def icu_download(path):
23882388

23892389
# always set icu_small, node.gyp depends on it being defined.
23902390
o['variables']['icu_small'] = b(False)
2391+
o['variables']['icu_system'] = b(False)
23912392

23922393
# prevent data override
23932394
o['defines'] += ['ICU_NO_USER_DATA_OVERRIDE']
@@ -2424,6 +2425,7 @@ def icu_download(path):
24242425
o['variables']['v8_enable_i18n_support'] = 1
24252426
elif with_intl == 'system-icu':
24262427
# ICU from pkg-config.
2428+
o['variables']['icu_system'] = b(True)
24272429
o['variables']['v8_enable_i18n_support'] = 1
24282430
pkgicu = pkg_config(['icu-i18n', 'icu-uc'])
24292431
if not pkgicu[0]:

test/parallel/test-temporal-with-zoneinfo.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ if (!process.config.variables.v8_enable_temporal_support) {
1212
if (!common.hasFullICU) {
1313
common.skip('Time zone support unavailable when not built with full ICU');
1414
}
15+
// TODO(aduh95): fix zoneinfo support with system-icu.
16+
if (process.config.variables.icu_system) {
17+
common.skip('Time zone support unavailable on --with-intl=system-icu builds');
18+
}
1519

1620
// Use globalThis.Temporal to workaround linter complaints.
1721
assert.strictEqual(typeof globalThis.Temporal, 'object');

0 commit comments

Comments
 (0)