Skip to content

Commit d80ff13

Browse files
committed
doc: include url.resolve() in DEP0169 application deprecation
Mark url.resolve() as deprecated Update also DEP0116 with cross-reference to DEP0169
1 parent abddfc9 commit d80ff13

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

doc/api/deprecations.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2660,11 +2660,15 @@ future release.
26602660

26612661
<!-- YAML
26622662
changes:
2663+
- version:
2664+
- v24.0.0
2665+
pr-url: https://github.com/nodejs/node/pull/55017
2666+
description: DEP0169 covers also `url.format()` and `url.resolve()`.
26632667
- version:
26642668
- v19.0.0
26652669
- v18.13.0
26662670
pr-url: https://github.com/nodejs/node/pull/44919
2667-
description: \`url.parse()` is deprecated again in DEP0169.
2671+
description: DEP0169 deprecates `url.parse()` again.
26682672
- version:
26692673
- v15.13.0
26702674
- v14.17.0
@@ -3778,7 +3782,7 @@ Type: Application (non-`node_modules` code only)
37783782
have security implications. Use the [WHATWG URL API][] instead. CVEs are not
37793783
issued for `url.parse()` vulnerabilities.
37803784

3781-
Passing a string argument to [`url.format()`][] invokes `url.parse()`
3785+
Calling [`url.format(urlString)`][] or [`url.resolve()`][] invokes `url.parse()`
37823786
internally, and is therefore also covered by this deprecation.
37833787

37843788
### DEP0170: Invalid port when using `url.parse()`
@@ -4592,6 +4596,7 @@ const server = http2.createSecureServer({
45924596
[`tls.createSecureContext()`]: tls.md#tlscreatesecurecontextoptions
45934597
[`tls.createServer()`]: tls.md#tlscreateserveroptions-secureconnectionlistener
45944598
[`url.format()`]: url.md#urlformaturlobject
4599+
[`url.format(urlString)`]: url.md#urlformaturlstring
45954600
[`url.parse()`]: url.md#urlparseurlstring-parsequerystring-slashesdenotehost
45964601
[`url.resolve()`]: url.md#urlresolvefrom-to
45974602
[`util._extend()`]: util.md#util_extendtarget-source

doc/api/url.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1956,6 +1956,10 @@ npx codemod@latest @nodejs/node-url-to-whatwg-url
19561956
<!-- YAML
19571957
added: v0.1.25
19581958
changes:
1959+
- version:
1960+
- v24.0.0
1961+
pr-url: https://github.com/nodejs/node/pull/55017
1962+
description: Deprecated again through DEP0169.
19591963
- version:
19601964
- v15.13.0
19611965
- v14.17.0
@@ -1979,6 +1983,8 @@ changes:
19791983
contains a hostname.
19801984
-->
19811985
1986+
> Stability: 0 - Deprecated: Use the WHATWG URL API instead.
1987+
19821988
* `from` {string} The base URL to use if `to` is a relative URL.
19831989
* `to` {string} The target URL to resolve.
19841990

0 commit comments

Comments
 (0)