build: remove duplicate C++ standard flags from LIEF

LIEF's lief.gyp explicitly sets -std=gnu++17 in cflags_cc and
xcode_settings, while common.gypi already sets -std=gnu++20
project-wide. This results in both flags being passed to the compiler
(-std=gnu++20 -std=gnu++17). Since the last flag wins, LIEF was
silently compiling as C++17 instead of the intended project-wide C++20.

Remove the explicit -std=gnu++17 flags from cflags_cc and
xcode_settings.OTHER_CPLUSPLUSFLAGS, and the msvs_settings
LanguageStandard override (stdcpp17), so LIEF uses the project-wide
C++20 standard.

Additionally, fix LIEF compilation with C++20 by explicitly qualifying
fmt::format and fmt::join in Section.cpp, and converting joined views
into std::string values prior to passing them into final formatting
calls. This prevents conflicts between fmt::join_view and std::format
when compiling under C++20.

Fixes: #62129

Author: om-ghante

deps/LIEF/lief.gyp

@@ -453,14 +453,7 @@
       'cflags': [
         '-fPIC'
       ],
-      # We need c++17 to compile without std::format and avoid conflicts with spdlog.
-      'msvs_settings': {
-        'VCCLCompilerTool': {
-          'LanguageStandard': 'stdcpp17',
-        },
-      },
       'cflags_cc': [
-        '-std=gnu++17',
         '-fPIC',
         '-fvisibility=hidden',
         '-fvisibility-inlines-hidden',
@@ -473,7 +466,6 @@
       ],
       'xcode_settings': {
         'OTHER_CPLUSPLUSFLAGS': [
-          '-std=gnu++17',
           '-fPIC',
           '-fvisibility=hidden',
           '-fvisibility-inlines-hidden',

deps/LIEF/src/COFF/Section.cpp

@@ -122,7 +122,7 @@ std::string Section::to_string() const {
                  [] (const char c) { return format("{:02x}", c); });
 
   os << format("{:{}} {} ({})\n", "Name:", WIDTH, name(),
-               join(fullname_hex, " "));
+               fmt::to_string(join(fullname_hex, " ")));
 
   os << format("{:{}} 0x{:x}\n", "Virtual Size", WIDTH, virtual_size())
      << format("{:{}} 0x{:x}\n", "Virtual Address", WIDTH, virtual_address())
@@ -134,7 +134,7 @@ std::string Section::to_string() const {
      << format("{:{}} 0x{:x}\n", "Pointer to line numbers", WIDTH, pointerto_line_numbers())
      << format("{:{}} 0x{:x}\n", "Number of relocations", WIDTH, numberof_relocations())
      << format("{:{}} 0x{:x}\n", "Number of lines", WIDTH, numberof_line_numbers())
-     << format("{:{}} {}", "Characteristics", WIDTH, join(list_str, ", "));
+     << format("{:{}} {}", "Characteristics", WIDTH, fmt::to_string(join(list_str, ", ")));
 
   return os.str();
 

deps/LIEF/src/PE/LoadConfigurations/LoadConfiguration.cpp

@@ -917,7 +917,7 @@ std::string LoadConfiguration::to_string() const {
 
   if (auto val = guard_flags(); val && *val != 0) {
     oss << format("{:{}} {}\n", "Guard Flags:", WIDTH,
-                  fmt::join(guard_cf_flags_list(), ","));
+                  fmt::to_string(fmt::join(guard_cf_flags_list(), ",")));
   }
 
   if (const CodeIntegrity* CI = code_integrity()) {

deps/LIEF/src/PE/Section.cpp

@@ -126,7 +126,6 @@ void Section::clear(uint8_t c) {
 }
 
 std::ostream& operator<<(std::ostream& os, const Section& section) {
-  using namespace fmt;
   static constexpr auto WIDTH = 24;
   const auto& list = section.characteristics_list();
   std::vector<std::string> list_str;
@@ -138,29 +137,34 @@ std::ostream& operator<<(std::ostream& os, const Section& section) {
   fullname_hex.reserve(section.name().size());
   std::transform(section.fullname().begin(), section.fullname().end(),
                  std::back_inserter(fullname_hex),
-                 [] (const char c) { return format("{:02x}", c); });
+                 [] (const char c) { return fmt::format("{:02x}", c); });
+
+  const std::string fullname_hex_joined =
+      fmt::format("{}", fmt::join(fullname_hex, " "));
+  const std::string characteristics_joined =
+      fmt::format("{}", fmt::join(list_str, ", "));
 
   if (const COFF::String* coff_str = section.coff_string()) {
-    os << format("{:{}} {} ({}, {})\n", "Name:", WIDTH, section.name(),
-                 join(fullname_hex, " "), coff_str->str());
+    os << fmt::format("{:{}} {} ({}, {})\n", "Name:", WIDTH, section.name(),
+                 fullname_hex_joined, coff_str->str());
   } else {
-    os << format("{:{}} {} ({})\n", "Name:", WIDTH, section.name(),
-                 join(fullname_hex, " "));
+    os << fmt::format("{:{}} {} ({})\n", "Name:", WIDTH, section.name(),
+                 fullname_hex_joined);
   }
 
-  os << format("{:{}} 0x{:x}\n", "Virtual Size", WIDTH, section.virtual_size())
-     << format("{:{}} 0x{:x}\n", "Virtual Address", WIDTH, section.virtual_address())
-     << format("{:{}} [0x{:08x}, 0x{:08x}]\n", "Range", WIDTH,
+  os << fmt::format("{:{}} 0x{:x}\n", "Virtual Size", WIDTH, section.virtual_size())
+     << fmt::format("{:{}} 0x{:x}\n", "Virtual Address", WIDTH, section.virtual_address())
+     << fmt::format("{:{}} [0x{:08x}, 0x{:08x}]\n", "Range", WIDTH,
                section.virtual_address(), section.virtual_address() + section.virtual_size())
-     << format("{:{}} 0x{:x}\n", "Size of raw data", WIDTH, section.sizeof_raw_data())
-     << format("{:{}} 0x{:x}\n", "Pointer to raw data", WIDTH, section.pointerto_raw_data())
-     << format("{:{}} [0x{:08x}, 0x{:08x}]\n", "Range", WIDTH,
+     << fmt::format("{:{}} 0x{:x}\n", "Size of raw data", WIDTH, section.sizeof_raw_data())
+     << fmt::format("{:{}} 0x{:x}\n", "Pointer to raw data", WIDTH, section.pointerto_raw_data())
+     << fmt::format("{:{}} [0x{:08x}, 0x{:08x}]\n", "Range", WIDTH,
                section.pointerto_raw_data(), section.pointerto_raw_data() + section.sizeof_raw_data())
-     << format("{:{}} 0x{:x}\n", "Pointer to relocations", WIDTH, section.pointerto_relocation())
-     << format("{:{}} 0x{:x}\n", "Pointer to line numbers", WIDTH, section.pointerto_line_numbers())
-     << format("{:{}} 0x{:x}\n", "Number of relocations", WIDTH, section.numberof_relocations())
-     << format("{:{}} 0x{:x}\n", "Number of lines", WIDTH, section.numberof_line_numbers())
-     << format("{:{}} {}", "Characteristics", WIDTH, join(list_str, ", "));
+     << fmt::format("{:{}} 0x{:x}\n", "Pointer to relocations", WIDTH, section.pointerto_relocation())
+     << fmt::format("{:{}} 0x{:x}\n", "Pointer to line numbers", WIDTH, section.pointerto_line_numbers())
+     << fmt::format("{:{}} 0x{:x}\n", "Number of relocations", WIDTH, section.numberof_relocations())
+     << fmt::format("{:{}} 0x{:x}\n", "Number of lines", WIDTH, section.numberof_line_numbers())
+     << fmt::format("{:{}} {}", "Characteristics", WIDTH, characteristics_joined);
   return os;
 }
 

deps/LIEF/src/PE/debug/ExDllCharacteristics.cpp

@@ -59,7 +59,7 @@ std::string ExDllCharacteristics::to_string() const {
   std::ostringstream os;
   using namespace fmt;
   os << Debug::to_string() << '\n'
-     << format("  Characteristics: {}", join(characteristics_list(), ", "));
+     << format("  Characteristics: {}", fmt::to_string(join(characteristics_list(), ", ")));
   return os.str();
 }
 

deps/LIEF/src/PE/layout_check.cpp

@@ -106,7 +106,7 @@ class LayoutChecker {
 
   template <typename... Args>
   bool error(const char *fmt, const Args &... args) {
-    error_msg = fmt::format(fmt, args...);
+    error_msg = fmt::format(fmt::runtime(fmt), args...);
     return false;
   }