Skip to content

Commit d8bc128

Browse files
Apply suggestions from code review
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
1 parent 44390d5 commit d8bc128

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lib/internal/vm.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ function isContext(object) {
4242

4343
/**
4444
* Retrieves the host-defined option ID based on the provided importModuleDynamically and hint.
45-
* @param {import('internal/modules/esm/utils').ImportModuleDynamicallyCallback | undefined} importModuleDynamically -
45+
* @param {import('internal/modules/esm/utils').ImportModuleDynamicallyCallback | symbol | undefined} importModuleDynamically -
4646
* The importModuleDynamically function or undefined.
4747
* @param {string} hint - The hint for the option ID.
4848
* @returns {symbol | import('internal/modules/esm/utils').ImportModuleDynamicallyCallback} - The host-defined option
@@ -82,7 +82,7 @@ function getHostDefinedOptionId(importModuleDynamically, hint) {
8282
/**
8383
* Registers a dynamically imported module for customization.
8484
* @param {string} referrer - The path of the referrer module.
85-
* @param {import('internal/modules/esm/utils').ImportModuleDynamicallyCallback} importModuleDynamically - The
85+
* @param {import('internal/modules/esm/utils').ImportModuleDynamicallyCallback | symbol} importModuleDynamically - The
8686
* dynamically imported module function to be registered.
8787
*/
8888
function registerImportModuleDynamically(referrer, importModuleDynamically) {
@@ -115,7 +115,7 @@ function registerImportModuleDynamically(referrer, importModuleDynamically) {
115115
* @param {object[]} [contextExtensions=[]] - An array of context extensions to use for the compiled function.
116116
* @param {string[]} [params] - An optional array of parameter names for the compiled function.
117117
* @param {symbol} hostDefinedOptionId - A symbol referenced by the field `host_defined_option_symbol`.
118-
* @param {import('internal/modules/esm/utils').ImportModuleDynamicallyCallback} [importModuleDynamically] -
118+
* @param {import('internal/modules/esm/utils').ImportModuleDynamicallyCallback | symbol} [importModuleDynamically] -
119119
* A function to use for dynamically importing modules.
120120
* @returns {object} An object containing the compiled function and any associated data.
121121
* @throws {TypeError} If any of the arguments are of the wrong type.
@@ -164,8 +164,8 @@ function internalCompileFunction(
164164
* @param {Buffer} cachedData - The cached data of the script.
165165
* @param {boolean} produceCachedData - Indicates whether to produce cached data.
166166
* @param {object} parsingContext - The parsing context of the script.
167-
* @param {number} hostDefinedOptionId - The host-defined option ID.
168-
* @param {boolean} importModuleDynamically - Indicates whether to import modules dynamically.
167+
* @param {symbol} hostDefinedOptionId - The host-defined option ID.
168+
* @param {import('internal/modules/esm/utils').ImportModuleDynamicallyCallback} importModuleDynamically - Indicates whether to import modules dynamically.
169169
* @returns {ContextifyScript} The created contextify script.
170170
*/
171171
function makeContextifyScript(code,

0 commit comments

Comments
 (0)