lib: cleanup stateless diffiehellman key handling

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

Author: panva

lib/internal/crypto/diffiehellman.js

@@ -5,7 +5,6 @@ const {
   FunctionPrototypeCall,
   MathCeil,
   ObjectDefineProperty,
-  SafeSet,
   TypedArrayPrototypeGetBuffer,
   Uint8Array,
 } = primordials;
@@ -26,10 +25,7 @@ const {
   codes: {
     ERR_CRYPTO_ECDH_INVALID_FORMAT,
     ERR_CRYPTO_ECDH_INVALID_PUBLIC_KEY,
-    ERR_CRYPTO_INCOMPATIBLE_KEY,
-    ERR_CRYPTO_INVALID_KEY_OBJECT_TYPE,
     ERR_INVALID_ARG_TYPE,
-    ERR_INVALID_ARG_VALUE,
   },
 } = require('internal/errors');
 
@@ -51,7 +47,6 @@ const {
 } = require('internal/util');
 
 const {
-  isKeyObject,
   kAlgorithm,
   kKeyType,
   preparePrivateKey,
@@ -276,8 +271,6 @@ function getFormat(format) {
   return POINT_CONVERSION_UNCOMPRESSED;
 }
 
-const dhEnabledKeyTypes = new SafeSet(['dh', 'ec', 'x448', 'x25519']);
-
 function diffieHellman(options, callback) {
   validateObject(options, 'options');
 
@@ -286,36 +279,6 @@ function diffieHellman(options, callback) {
 
   const { privateKey, publicKey } = options;
 
-  // TODO(@panva): remove these non-semver-major error code preserving measures
-  // in a semver-major followup, the final state is just preparePublicOrPrivateKey
-  // and preparePrivateKey
-  if (privateKey == null)
-    throw new ERR_INVALID_ARG_VALUE('options.privateKey', privateKey);
-
-  if (publicKey == null)
-    throw new ERR_INVALID_ARG_VALUE('options.publicKey', publicKey);
-
-  if (isKeyObject(privateKey)) {
-    if (privateKey.type !== 'private')
-      throw new ERR_CRYPTO_INVALID_KEY_OBJECT_TYPE(privateKey.type, 'private');
-  }
-
-  if (isKeyObject(publicKey)) {
-    if (publicKey.type !== 'public' && publicKey.type !== 'private') {
-      throw new ERR_CRYPTO_INVALID_KEY_OBJECT_TYPE(publicKey.type,
-                                                   'private or public');
-    }
-  }
-
-  if (isKeyObject(privateKey) && isKeyObject(publicKey)) {
-    const privateType = privateKey.asymmetricKeyType;
-    const publicType = publicKey.asymmetricKeyType;
-    if (privateType !== publicType || !dhEnabledKeyTypes.has(privateType)) {
-      throw new ERR_CRYPTO_INCOMPATIBLE_KEY('key types for Diffie-Hellman',
-                                            `${privateType} and ${publicType}`);
-    }
-  }
-
   const {
     data: pubData,
     format: pubFormat,