Skip to content

Commit e4c82ea

Browse files
committed
expose keepAlive symbols from net for testing
1 parent 937d582 commit e4c82ea

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

lib/internal/net.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,9 @@ function isLoopback(host) {
100100

101101
module.exports = {
102102
kReinitializeHandle: Symbol('kReinitializeHandle'),
103+
kSetNoDelay: Symbol('kSetNoDelay'),
104+
kSetKeepAlive: Symbol('kSetKeepAlive'),
105+
kSetKeepAliveInitialDelay: Symbol('kSetKeepAliveInitialDelay'),
103106
isIP,
104107
isIPv4,
105108
isIPv6,

lib/net.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ let debug = require('internal/util/debuglog').debuglog('net', (fn) => {
4848
});
4949
const {
5050
kReinitializeHandle,
51+
kSetNoDelay,
52+
kSetKeepAlive,
53+
kSetKeepAliveInitialDelay,
5154
isIP,
5255
isIPv4,
5356
isIPv6,
@@ -356,9 +359,6 @@ function closeSocketHandle(self, isException, isCleanupPending = false) {
356359

357360
const kBytesRead = Symbol('kBytesRead');
358361
const kBytesWritten = Symbol('kBytesWritten');
359-
const kSetNoDelay = Symbol('kSetNoDelay');
360-
const kSetKeepAlive = Symbol('kSetKeepAlive');
361-
const kSetKeepAliveInitialDelay = Symbol('kSetKeepAliveInitialDelay');
362362
const kSetTOS = Symbol('kSetTOS');
363363

364364
function Socket(options) {

test/parallel/test-tls-connect-keepalive-nodelay.js

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// Flags: --expose-internals
12
'use strict';
23

34
const common = require('../common');
@@ -9,21 +10,17 @@ if (!common.hasCrypto)
910
common.skip('missing crypto');
1011

1112
const assert = require('assert');
12-
const net = require('net');
1313
const tls = require('tls');
1414
const fixtures = require('../common/fixtures');
15+
const {
16+
kSetNoDelay,
17+
kSetKeepAlive,
18+
kSetKeepAliveInitialDelay,
19+
} = require('internal/net');
1520

1621
const key = fixtures.readKey('agent1-key.pem');
1722
const cert = fixtures.readKey('agent1-cert.pem');
1823

19-
// Retrieve internal symbols used by net.Socket to store socket options.
20-
const symbols = Object.getOwnPropertySymbols(new net.Socket());
21-
const kSetNoDelay = symbols.find((s) => s.toString() === 'Symbol(kSetNoDelay)');
22-
const kSetKeepAlive =
23-
symbols.find((s) => s.toString() === 'Symbol(kSetKeepAlive)');
24-
const kSetKeepAliveInitialDelay =
25-
symbols.find((s) => s.toString() === 'Symbol(kSetKeepAliveInitialDelay)');
26-
2724
// Test: keepAlive, keepAliveInitialDelay, and noDelay
2825
{
2926
const server = tls.createServer({ key, cert }, (socket) => {

0 commit comments

Comments
 (0)