Skip to content

Commit e9786c4

Browse files
committed
async_hooks: add using scopes to AsyncLocalStorage
Adds support for using scope = storage.withScope(data) to do the equivalent of a storage.run(data, fn) with using syntax. This enables avoiding unnecessary closures.
1 parent 3db2206 commit e9786c4

File tree

5 files changed

+329
-0
lines changed

5 files changed

+329
-0
lines changed

doc/api/async_context.md

Lines changed: 122 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -386,6 +386,110 @@ try {
386386
}
387387
```
388388

389+
### `asyncLocalStorage.withScope(store)`
390+
391+
<!-- YAML
392+
added: REPLACEME
393+
-->
394+
395+
> Stability: 1 - Experimental
396+
397+
* `store` {any}
398+
* Returns: {RunScope}
399+
400+
Creates a disposable scope that enters the given store and automatically
401+
restores the previous store value when the scope is disposed. This method is
402+
designed to work with JavaScript's explicit resource management (`using` syntax).
403+
404+
Example:
405+
406+
```mjs
407+
import { AsyncLocalStorage } from 'node:async_hooks';
408+
409+
const asyncLocalStorage = new AsyncLocalStorage();
410+
411+
{
412+
using _ = asyncLocalStorage.withScope('my-store');
413+
console.log(asyncLocalStorage.getStore()); // Prints: my-store
414+
}
415+
416+
console.log(asyncLocalStorage.getStore()); // Prints: undefined
417+
```
418+
419+
```cjs
420+
const { AsyncLocalStorage } = require('node:async_hooks');
421+
422+
const asyncLocalStorage = new AsyncLocalStorage();
423+
424+
{
425+
using _ = asyncLocalStorage.withScope('my-store');
426+
console.log(asyncLocalStorage.getStore()); // Prints: my-store
427+
}
428+
429+
console.log(asyncLocalStorage.getStore()); // Prints: undefined
430+
```
431+
432+
The `withScope()` method is particularly useful for managing context in
433+
synchronous code where you want to ensure the previous store value is restored
434+
when exiting a block, even if an error is thrown.
435+
436+
```mjs
437+
import { AsyncLocalStorage } from 'node:async_hooks';
438+
439+
const asyncLocalStorage = new AsyncLocalStorage();
440+
441+
try {
442+
using _ = asyncLocalStorage.withScope('my-store');
443+
console.log(asyncLocalStorage.getStore()); // Prints: my-store
444+
throw new Error('test');
445+
} catch (e) {
446+
// Store is automatically restored even after error
447+
console.log(asyncLocalStorage.getStore()); // Prints: undefined
448+
}
449+
```
450+
451+
```cjs
452+
const { AsyncLocalStorage } = require('node:async_hooks');
453+
454+
const asyncLocalStorage = new AsyncLocalStorage();
455+
456+
try {
457+
using _ = asyncLocalStorage.withScope('my-store');
458+
console.log(asyncLocalStorage.getStore()); // Prints: my-store
459+
throw new Error('test');
460+
} catch (e) {
461+
// Store is automatically restored even after error
462+
console.log(asyncLocalStorage.getStore()); // Prints: undefined
463+
}
464+
```
465+
466+
**Important:** When using `withScope()` in async functions before the first
467+
`await`, be aware that the scope change will affect the caller's context. The
468+
synchronous portion of an async function (before the first `await`) runs
469+
immediately when called, and when it reaches the first `await`, it returns the
470+
promise to the caller. At that point, the scope change becomes visible in the
471+
caller's context and will persist in subsequent synchronous code until something
472+
else changes the scope value. For async operations, prefer using `run()` which
473+
properly isolates context across async boundaries.
474+
475+
```mjs
476+
import { AsyncLocalStorage } from 'node:async_hooks';
477+
478+
const asyncLocalStorage = new AsyncLocalStorage();
479+
480+
async function example() {
481+
using _ = asyncLocalStorage.withScope('my-store');
482+
console.log(asyncLocalStorage.getStore()); // Prints: my-store
483+
await someAsyncOperation(); // Function pauses here and returns promise
484+
console.log(asyncLocalStorage.getStore()); // Prints: my-store
485+
}
486+
487+
// Calling without await
488+
example(); // Synchronous portion runs, then pauses at first await
489+
// After the promise is returned, the scope 'my-store' is now active in caller!
490+
console.log(asyncLocalStorage.getStore()); // Prints: my-store (unexpected!)
491+
```
492+
389493
### Usage with `async/await`
390494

391495
If, within an async function, only one `await` call is to run within a context,
@@ -420,6 +524,22 @@ of `asyncLocalStorage.getStore()` after the calls you suspect are responsible
420524
for the loss. When the code logs `undefined`, the last callback called is
421525
probably responsible for the context loss.
422526

527+
## Class: `RunScope`
528+
529+
<!-- YAML
530+
added: REPLACEME
531+
-->
532+
533+
> Stability: 1 - Experimental
534+
535+
A disposable scope returned by [`asyncLocalStorage.withScope()`][] that
536+
automatically restores the previous store value when disposed. This class
537+
implements the [Explicit Resource Management][] protocol and is designed to work
538+
with JavaScript's `using` syntax.
539+
540+
The scope automatically restores the previous store value when the `using` block
541+
exits, whether through normal completion or by throwing an error.
542+
423543
## Class: `AsyncResource`
424544

425545
<!-- YAML
@@ -905,8 +1025,10 @@ const server = createServer((req, res) => {
9051025
}).listen(3000);
9061026
```
9071027
1028+
[Explicit Resource Management]: https://github.com/tc39/proposal-explicit-resource-management
9081029
[`AsyncResource`]: #class-asyncresource
9091030
[`EventEmitter`]: events.md#class-eventemitter
9101031
[`Stream`]: stream.md#stream
9111032
[`Worker`]: worker_threads.md#class-worker
1033+
[`asyncLocalStorage.withScope()`]: #asynclocalstoragewithscopestore
9121034
[`util.promisify()`]: util.md#utilpromisifyoriginal

lib/internal/async_local_storage/async_context_frame.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ const {
1212
const AsyncContextFrame = require('internal/async_context_frame');
1313
const { AsyncResource } = require('async_hooks');
1414

15+
const RunScope = require('internal/async_local_storage/run_scope');
16+
1517
class AsyncLocalStorage {
1618
#defaultValue = undefined;
1719
#name = undefined;
@@ -77,6 +79,10 @@ class AsyncLocalStorage {
7779
}
7880
return frame?.get(this);
7981
}
82+
83+
withScope(store) {
84+
return new RunScope(this, store);
85+
}
8086
}
8187

8288
module.exports = AsyncLocalStorage;

lib/internal/async_local_storage/async_hooks.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ const {
1919
executionAsyncResource,
2020
} = require('async_hooks');
2121

22+
const RunScope = require('internal/async_local_storage/run_scope');
23+
2224
const storageList = [];
2325
const storageHook = createHook({
2426
init(asyncId, type, triggerAsyncId, resource) {
@@ -142,6 +144,10 @@ class AsyncLocalStorage {
142144
}
143145
return this.#defaultValue;
144146
}
147+
148+
withScope(store) {
149+
return new RunScope(this, store);
150+
}
145151
}
146152

147153
module.exports = AsyncLocalStorage;
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
'use strict';
2+
3+
const {
4+
SymbolDispose,
5+
} = primordials;
6+
7+
class RunScope {
8+
#storage;
9+
#previousStore;
10+
#disposed = false;
11+
12+
constructor(storage, store) {
13+
this.#storage = storage;
14+
this.#previousStore = storage.getStore();
15+
storage.enterWith(store);
16+
}
17+
18+
[SymbolDispose]() {
19+
if (this.#disposed) {
20+
return;
21+
}
22+
this.#disposed = true;
23+
this.#storage.enterWith(this.#previousStore);
24+
}
25+
}
26+
27+
module.exports = RunScope;
Lines changed: 168 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,168 @@
1+
/* eslint-disable no-unused-vars */
2+
'use strict';
3+
require('../common');
4+
const assert = require('node:assert');
5+
const { AsyncLocalStorage } = require('node:async_hooks');
6+
7+
// Test basic RunScope with using
8+
{
9+
const storage = new AsyncLocalStorage();
10+
11+
assert.strictEqual(storage.getStore(), undefined);
12+
13+
{
14+
using scope = storage.withScope('test');
15+
assert.strictEqual(storage.getStore(), 'test');
16+
}
17+
18+
// Store should be restored to undefined
19+
assert.strictEqual(storage.getStore(), undefined);
20+
}
21+
22+
// Test RunScope restores previous value
23+
{
24+
const storage = new AsyncLocalStorage();
25+
26+
storage.enterWith('initial');
27+
assert.strictEqual(storage.getStore(), 'initial');
28+
29+
{
30+
using scope = storage.withScope('scoped');
31+
assert.strictEqual(storage.getStore(), 'scoped');
32+
}
33+
34+
// Should restore to previous value
35+
assert.strictEqual(storage.getStore(), 'initial');
36+
}
37+
38+
// Test nested RunScope
39+
{
40+
const storage = new AsyncLocalStorage();
41+
const storeValues = [];
42+
43+
{
44+
using outer = storage.withScope('outer');
45+
storeValues.push(storage.getStore());
46+
47+
{
48+
using inner = storage.withScope('inner');
49+
storeValues.push(storage.getStore());
50+
}
51+
52+
// Should restore to outer
53+
storeValues.push(storage.getStore());
54+
}
55+
56+
// Should restore to undefined
57+
storeValues.push(storage.getStore());
58+
59+
assert.deepStrictEqual(storeValues, ['outer', 'inner', 'outer', undefined]);
60+
}
61+
62+
// Test RunScope with error during usage
63+
{
64+
const storage = new AsyncLocalStorage();
65+
66+
storage.enterWith('before');
67+
68+
const testError = new Error('test');
69+
70+
assert.throws(() => {
71+
using scope = storage.withScope('during');
72+
assert.strictEqual(storage.getStore(), 'during');
73+
throw testError;
74+
}, testError);
75+
76+
// Store should be restored even after error
77+
assert.strictEqual(storage.getStore(), 'before');
78+
}
79+
80+
// Test idempotent disposal
81+
{
82+
const storage = new AsyncLocalStorage();
83+
84+
const scope = storage.withScope('test');
85+
assert.strictEqual(storage.getStore(), 'test');
86+
87+
// Dispose via Symbol.dispose
88+
scope[Symbol.dispose]();
89+
assert.strictEqual(storage.getStore(), undefined);
90+
91+
storage.enterWith('test2');
92+
assert.strictEqual(storage.getStore(), 'test2');
93+
94+
// Double dispose should be idempotent
95+
scope[Symbol.dispose]();
96+
assert.strictEqual(storage.getStore(), 'test2');
97+
}
98+
99+
// Test RunScope with defaultValue
100+
{
101+
const storage = new AsyncLocalStorage({ defaultValue: 'default' });
102+
103+
assert.strictEqual(storage.getStore(), 'default');
104+
105+
{
106+
using scope = storage.withScope('custom');
107+
assert.strictEqual(storage.getStore(), 'custom');
108+
}
109+
110+
// Should restore to default
111+
assert.strictEqual(storage.getStore(), 'default');
112+
}
113+
114+
// Test deeply nested RunScope
115+
{
116+
const storage = new AsyncLocalStorage();
117+
118+
{
119+
using s1 = storage.withScope(1);
120+
assert.strictEqual(storage.getStore(), 1);
121+
122+
{
123+
using s2 = storage.withScope(2);
124+
assert.strictEqual(storage.getStore(), 2);
125+
126+
{
127+
using s3 = storage.withScope(3);
128+
assert.strictEqual(storage.getStore(), 3);
129+
130+
{
131+
using s4 = storage.withScope(4);
132+
assert.strictEqual(storage.getStore(), 4);
133+
}
134+
135+
assert.strictEqual(storage.getStore(), 3);
136+
}
137+
138+
assert.strictEqual(storage.getStore(), 2);
139+
}
140+
141+
assert.strictEqual(storage.getStore(), 1);
142+
}
143+
144+
assert.strictEqual(storage.getStore(), undefined);
145+
}
146+
147+
// Test RunScope with multiple storages
148+
{
149+
const storage1 = new AsyncLocalStorage();
150+
const storage2 = new AsyncLocalStorage();
151+
152+
{
153+
using scope1 = storage1.withScope('A');
154+
155+
{
156+
using scope2 = storage2.withScope('B');
157+
158+
assert.strictEqual(storage1.getStore(), 'A');
159+
assert.strictEqual(storage2.getStore(), 'B');
160+
}
161+
162+
assert.strictEqual(storage1.getStore(), 'A');
163+
assert.strictEqual(storage2.getStore(), undefined);
164+
}
165+
166+
assert.strictEqual(storage1.getStore(), undefined);
167+
assert.strictEqual(storage2.getStore(), undefined);
168+
}

0 commit comments

Comments
 (0)