vfs: convert isVfsEnabled from property to method

Convert isVfsEnabled from a boolean property set during Initialize()
to a SetMethod function, matching the isSea() pattern. This addresses
review feedback requesting consistency in the C++ binding API.

Author: mcollina

lib/internal/main/embedding.js

@@ -14,7 +14,7 @@ const {
 } = require('internal/process/pre_execution');
 const {
   isSea,
-  isVfsEnabled: isVfsEnabledFlag,
+  isVfsEnabled: isVfsEnabledFn,
   mainCodePath: seaMainCodePath,
   isExperimentalSeaWarningNeeded,
 } = internalBinding('sea');
@@ -113,7 +113,7 @@ function initSeaVfs() {
   if (seaVfsInitialized) return;
   seaVfsInitialized = true;
 
-  if (!isLoadingSea || !isVfsEnabledFlag) return;
+  if (!isLoadingSea || !isVfsEnabledFn()) return;
 
   const { getSeaVfs } = require('internal/vfs/sea');
   const seaVfs = getSeaVfs();

lib/internal/vfs/sea.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { isSea, isVfsEnabled, getAssetKeys } = internalBinding('sea');
+const { isSea, isVfsEnabled: isVfsEnabledFn, getAssetKeys } = internalBinding('sea');
 const { kEmptyObject, getLazy } = require('internal/util');
 const {
   codes: {
@@ -30,7 +30,7 @@ const lazySEAProvider = getLazy(
  * @returns {VirtualFileSystem|null} The VFS instance, or null if not running as SEA or no assets
  */
 function createSeaVfs(options = kEmptyObject) {
-  if (!isSea || !isVfsEnabled) {
+  if (!isSea || !isVfsEnabledFn()) {
     return null;
   }
 

src/node_sea.cc

@@ -266,6 +266,15 @@ void IsSea(const FunctionCallbackInfo<Value>& args) {
   args.GetReturnValue().Set(IsSingleExecutable());
 }
 
+void IsVfsEnabled(const FunctionCallbackInfo<Value>& args) {
+  bool enabled = false;
+  if (IsSingleExecutable()) {
+    SeaResource sea_resource = FindSingleExecutableResource();
+    enabled = static_cast<bool>(sea_resource.flags & SeaFlags::kEnableVfs);
+  }
+  args.GetReturnValue().Set(enabled);
+}
+
 void IsExperimentalSeaWarningNeeded(const FunctionCallbackInfo<Value>& args) {
   bool is_building_sea =
       !per_process::cli_options->experimental_sea_config.empty();
@@ -952,11 +961,9 @@ void Initialize(Local<Object> target,
   Environment* env = Environment::GetCurrent(context);
   Isolate* isolate = env->isolate();
 
-  // isVfsEnabled is a boolean property (only used by embedding.js).
-  bool is_vfs_enabled = false;
   if (IsSingleExecutable()) {
     SeaResource sea_resource = FindSingleExecutableResource();
-    is_vfs_enabled =
+    bool is_vfs_enabled =
         static_cast<bool>(sea_resource.flags & SeaFlags::kEnableVfs);
     // Expose the main code path so VFS can construct the correct entry point.
     if (is_vfs_enabled) {
@@ -974,13 +981,9 @@ void Initialize(Local<Object> target,
       }
     }
   }
-  target
-      ->Set(context,
-            FIXED_ONE_BYTE_STRING(isolate, "isVfsEnabled"),
-            Boolean::New(isolate, is_vfs_enabled))
-      .Check();
 
   SetMethod(context, target, "isSea", IsSea);
+  SetMethod(context, target, "isVfsEnabled", IsVfsEnabled);
   SetMethod(context,
             target,
             "isExperimentalSeaWarningNeeded",
@@ -991,6 +994,7 @@ void Initialize(Local<Object> target,
 
 void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
   registry->Register(IsSea);
+  registry->Register(IsVfsEnabled);
   registry->Register(IsExperimentalSeaWarningNeeded);
   registry->Register(GetAsset);
   registry->Register(GetAssetKeys);