Skip to content

Commit f1c9e37

Browse files
committed
squash! review feedback
1 parent a021c17 commit f1c9e37

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

test/node-api/test_buffer/binding.gyp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"target_name": "test_buffer",
55
"defines": [
66
"NAPI_EXPERIMENTAL",
7-
"NAPI_VERSION=10",
87
"NODE_API_EXPERIMENTAL_NO_WARNING"
98
],
109
"sources": [ "test_buffer.c" ]

test/node-api/test_buffer/test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
const common = require('../../common');
55
const binding = require(`./build/${common.buildType}/test_buffer`);
66
const assert = require('assert');
7-
const tick = require('util').promisify(require('../../common/tick'));
7+
const util = require('util');
8+
const tick = util.promisify(require('../../common/tick'));
89

910
(async function() {
1011
assert.strictEqual(binding.newBuffer().toString(), binding.theText);
@@ -30,6 +31,7 @@ const tick = require('util').promisify(require('../../common/tick'));
3031
// store is reclaimed; at least some of the time it happens even before
3132
// calling gc().
3233
let sab = binding.newExternalSharedArrayBuffer();
34+
assert(util.types.isSharedArrayBuffer(sab));
3335
sab = null; // eslint-disable-line no-unused-vars
3436
global.gc();
3537
await tick(10);

0 commit comments

Comments
 (0)