squash! introduce node_api_noenv_finalize

Author: bnoordhuis

doc/api/n-api.md

@@ -2586,9 +2586,7 @@ napi_status
 node_api_create_external_sharedarraybuffer(napi_env env,
                                            void* external_data,
                                            size_t byte_length,
-                                           void (*finalize_cb)(
-                                              void* external_data,
-                                              void* finalize_hint),
+                                           node_api_noenv_finalize finalize_cb,
                                            void* finalize_hint,
                                            napi_value* result)
 ```

src/js_native_api.h

@@ -443,7 +443,7 @@ NAPI_EXTERN napi_status NAPI_CDECL node_api_create_external_sharedarraybuffer(
     napi_env env,
     void* external_data,
     size_t byte_length,
-    void (*finalize_cb)(void* external_data, void* finalize_hint),
+    node_api_noenv_finalize finalize_cb,
     void* finalize_hint,
     napi_value* result);
 #endif  // NAPI_EXPERIMENTAL

src/js_native_api_types.h

@@ -188,6 +188,10 @@ typedef void(NAPI_CDECL* node_api_nogc_finalize)(node_api_nogc_env env,
 #endif
 typedef node_api_nogc_finalize node_api_basic_finalize;
 
+// A finalizer that can be called from any thread and at any time.
+typedef void(NAPI_CDECL* node_api_noenv_finalize)(void* finalize_data,
+                                                  void* finalize_hint);
+
 typedef struct {
   // One of utf8name or name should be NULL.
   const char* utf8name;

src/js_native_api_v8.cc

@@ -3138,7 +3138,7 @@ napi_status NAPI_CDECL node_api_create_external_sharedarraybuffer(
     napi_env env,
     void* external_data,
     size_t byte_length,
-    void (*finalize_cb)(void* external_data, void* finalize_hint),
+    node_api_noenv_finalize finalize_cb,
     void* finalize_hint,
     napi_value* result) {
   NAPI_PREAMBLE(env);