-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
Speed up async hooks (former domain module) #57724
Copy link
Copy link
Closed
Labels
async_hooksIssues and PRs related to the async hooks subsystem.Issues and PRs related to the async hooks subsystem.feature requestIssues that request new features to be added to Node.js.Issues that request new features to be added to Node.js.
Metadata
Metadata
Assignees
Labels
async_hooksIssues and PRs related to the async hooks subsystem.Issues and PRs related to the async hooks subsystem.feature requestIssues that request new features to be added to Node.js.Issues that request new features to be added to Node.js.
Type
Projects
Status
Awaiting Triage
What is the problem this feature will solve?
the current async_hooks implementation of the deprecated domain module runs about the same speed as original domain implementation
as a relatively unbiased observer both new and old implementations will slow a server down by around 30%
with current async/await uncaught exceptions are less of an issue
but still might be good to investigate how to optimize it - something makes it slow - probably a lot of function binding calls
@isaacs
What is the feature you are proposing to solve the problem?
perf optimizations
What alternatives have you considered?
its a core thing