-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
Leftovers after test-child-process-exec-abortcontroller-promisified #58118
Copy link
Copy link
Open
Labels
abortcontrollerIssues and PRs related to the AbortController APIIssues and PRs related to the AbortController APIchild_processIssues and PRs related to the child_process subsystem.Issues and PRs related to the child_process subsystem.staletestIssues and PRs related to the tests.Issues and PRs related to the tests.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Metadata
Metadata
Assignees
Labels
abortcontrollerIssues and PRs related to the AbortController APIIssues and PRs related to the AbortController APIchild_processIssues and PRs related to the child_process subsystem.Issues and PRs related to the child_process subsystem.staletestIssues and PRs related to the tests.Issues and PRs related to the tests.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
It seems test-child-process-exec-abortcontroller-promisified doesn't cleanup correct as I see 2 running node.js processes afterwards.
On my local windows I see two instances of
node.exe" -e "setInterval(()=>{}, 99)"after this test.ProcessExplorer shows they are in suspended state.
Seems like the actual cause are the last two tests where
AbortSignal.abort(err)is done before callingexecPromisifed.Not sure if this is just at test problem or a real bug.