Skip to content

buffer: cleanup handling different types buffers#54439

Closed
ronag wants to merge 1 commit intonodejs:mainfrom
nxtedition:buffer-types
Closed

buffer: cleanup handling different types buffers#54439
ronag wants to merge 1 commit intonodejs:mainfrom
nxtedition:buffer-types

Conversation

@ronag
Copy link
Copy Markdown
Member

@ronag ronag commented Aug 18, 2024

No description provided.

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Aug 18, 2024
@ronag ronag force-pushed the buffer-types branch 2 times, most recently from b70e585 to e0af1f9 Compare August 18, 2024 13:58
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 18, 2024

Codecov Report

❌ Patch coverage is 69.49153% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.27%. Comparing base (e4f61de) to head (4a17f1f).
⚠️ Report is 4185 commits behind head on main.

Files with missing lines Patch % Lines
lib/buffer.js 69.49% 15 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54439      +/-   ##
==========================================
- Coverage   87.33%   87.27%   -0.06%     
==========================================
  Files         648      648              
  Lines      182321   182331      +10     
  Branches    34971    34968       -3     
==========================================
- Hits       159222   159135      -87     
- Misses      16374    16455      +81     
- Partials     6725     6741      +16     
Files with missing lines Coverage Δ
lib/buffer.js 92.80% <69.49%> (-3.91%) ⬇️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ronag added a commit to nxtedition/node that referenced this pull request Apr 10, 2026
PR-URL: nodejs#54439
Assisted-by: Claude Code:Opus 4.6
ronag added a commit to nxtedition/node that referenced this pull request Apr 10, 2026
PR-URL: nodejs#54439
Assisted-by: Claude Code:Opus 4.6
ronag added a commit to nxtedition/node that referenced this pull request Apr 10, 2026
PR-URL: nodejs#54439
Assisted-by: Claude Code:Opus 4.6
@ronag ronag marked this pull request as draft April 10, 2026 07:02
PR-URL: nodejs#54439
Assisted-by: Claude Code:Opus 4.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants