Skip to content

test: fix internet/test-dns #59660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Aug 30, 2025
+3 −3
Merged

test: fix internet/test-dns #59660

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1edf1ad
test: fix internet/test-dns
targos Aug 28, 2025
9461452
lint
targos Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/internet/test-dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,9 +523,9 @@

TEST(async function test_resolveTxt(done) {
function validateResult(result) {
assert.ok(Array.isArray(result[0]));
assert.strictEqual(result.length, 1);
assert(result[0][0].startsWith('v=spf1'));
assert.ok(result.length > 0);
assert.ok(result.every(elem => Array.isArray(elem) && elem.length === 1));

Check failure on line 527 in test/internet/test-dns.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Expected parentheses around arrow function argument
Comment thread
aduh95 marked this conversation as resolved.
Outdated
assert.ok(result.some(elem => elem[0].startsWith('v=spf1')));

Check failure on line 528 in test/internet/test-dns.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Expected parentheses around arrow function argument
Comment thread
aduh95 marked this conversation as resolved.
Outdated
}

validateResult(await dnsPromises.resolveTxt(addresses.TXT_HOST));
Expand Down
Loading