Open
Conversation
Collaborator
|
Review requested:
|
mcollina
added
the
semver-major
nodejs-github-bot
added
async_hooks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61095 +/- ##
========================================
Coverage 89.71% 89.71%
========================================
Files 692 695 +3
Lines 213988 214663 +675
Branches 41054 41094 +40
========================================
+ Hits 191976 192590 +614
- Misses 14086 14138 +52
- Partials 7926 7935 +9
🚀 New features to boost your workflow:
|
RafaelGSS
reviewed
Dec 17, 2025
anonrig
approved these changes
Dec 18, 2025
mcollina
force-pushed
the
domain-als-port-v2
branch
2 times, most recently
from
b307f20 to
1d24947
Compare
RafaelGSS
approved these changes
Dec 18, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Flarna
reviewed
Dec 19, 2025
Member
Flarna
left a comment
Flarna
left a comment
There was a problem hiding this comment.
I have to admit that I do not fully understand domains so take my review with a grain of salt.
ronag
approved these changes
Jan 11, 2026
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Member
|
@mcollina seems this requires a rebase |
AugustinMauroy
approved these changes
Mar 29, 2026
| The `domain` property on async resources and `MakeCallback` has been removed. | ||
| The domain module now uses `AsyncLocalStorage` for context propagation instead | ||
| of `async_hooks`. Accessing the `domain` property on `AsyncResource` will throw | ||
| an error. Use `AsyncLocalStorage` instead for context propagation. |
Member
There was a problem hiding this comment.
Matteo is it possible to have a before/after example of this depreciation?
mcollina
force-pushed
the
domain-als-port-v2
branch
from
1eda843 to
23abf1e
Compare
Port the domain module from createHook (async_hooks) to AsyncLocalStorage using the AsyncContextFrame-based implementation. Key changes: - Use AsyncLocalStorage for domain context propagation instead of async_hooks.createHook() - Lazy initialization that triggers AsyncContextFrame prototype swap on first domain use - Use enterWith instead of ALS.run() so domain context is NOT automatically restored on exception - this matches the original domain.run() behavior where exit() only runs on success - Add ERR_ASYNC_RESOURCE_DOMAIN_REMOVED error for AsyncResource.domain - Update DEP0097 to End-of-Life status - Remove tests that relied on the removed MakeCallback domain property The domain module now uses the AsyncContextFrame version of AsyncLocalStorage directly for proper context propagation across async boundaries.
Remove the useDomainTrampoline function and related domain_cb variable that are no longer used after domain was ported to AsyncLocalStorage.
The test no longer tests async-id map leaks. Rename to reflect its actual purpose: verifying that accessing domain property on AsyncResource throws ERR_ASYNC_RESOURCE_DOMAIN_REMOVED.
Use require('async_hooks').AsyncLocalStorage instead of directly
importing internal modules. This allows proper auto-selection of
the ALS implementation based on --async-context-frame flag.
Extract common domain context setup/teardown logic into a single runInDomain helper function, reducing code duplication.
When an EventEmitter emits 'error' and the domain's error handler throws, the exception should propagate to the parent domain, not recursively call the same domain's error handler. The bug was that currentDomain/currentStack were not updated when temporarily switching to the parent domain context during error emission. Since domainExceptionHandler checks currentDomain first, exceptions would incorrectly route back to the same domain. Fixes by updating currentDomain/currentStack alongside the ALS store.
mcollina
force-pushed
the
domain-als-port-v2
branch
from
23abf1e to
6adae72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the domain module from createHook (async_hooks) to AsyncLocalStorage using the AsyncContextFrame-based implementation.
Key changes:
The domain module now uses the AsyncContextFrame version of AsyncLocalStorage directly for proper context propagation across async boundaries.