Skip to content

benchmark: add benchmark utility for Error instance #61180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mertcanaltin wants to merge 9 commits into from
Closed

benchmark: add benchmark utility for Error instance #61180

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3b40faf
benchmark: add benchmark utility for isNativeError function
mertcanaltin Dec 27, 2025
5fcf423
repair benchmark
mertcanaltin Dec 27, 2025
9de3f6f
refine test arguments and measure elapsed time in isNativeError bench…
mertcanaltin Dec 28, 2025
c4aaa5d
simplify isNativeError test arguments and remove performance logging
mertcanaltin Dec 28, 2025
23955ed
store result of isNativeError function for validation
mertcanaltin Dec 30, 2025
f2e53f1
add benchmark utility for isError function
mertcanaltin Dec 30, 2025
6b26012
refactor benchmark utility for isError function to improve readability
mertcanaltin Dec 30, 2025
8c79e29
add benchmark utility for isNativeError function
mertcanaltin Dec 30, 2025
a0f0062
Merge branch 'main' into mert/create/benchmark/isNativeError
mertcanaltin Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions benchmark/util/is-native-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
'use strict';

const common = require('../common');

const args = {
true: new Error('test'),
falsePrimitive: 42,
falseObject: { foo: 'bar' },
};

const bench = common.createBenchmark(
main,
{
argument: ['true'],
version: ['native'],
Comment thread
H4ad marked this conversation as resolved.
Outdated
n: [1e6],
},
{
flags: ['--expose-internals', '--no-warnings'],
},
);

function main({ argument, version, n }) {
const util = common.binding('util');
const types = require('internal/util/types');

const func = { native: util, js: types }[version].isNativeError;
Copy link
Copy Markdown
Member

@RafaelGSS RafaelGSS Dec 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't recently deprecated?

node/doc/api/deprecations.md

Line 4283 in 20bf328

### DEP0197: `util.types.isNativeError()`

Copy link
Copy Markdown
Member Author

@mertcanaltin mertcanaltin Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is deprecated but still supported - we should still not regress on stable releases and this change ensures that @RafaelGSS

Copy link
Copy Markdown
Member

@RafaelGSS RafaelGSS Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, what's the point of this benchmark? I mean, if we see util/isNativeError is slower, what it means afterall? Which API will be directly impacted besides the deprecated API?

Copy link
Copy Markdown
Member Author

@mertcanaltin mertcanaltin Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comparison ensures that existing users will not experience performance drops or unexpected slowdowns until the API is completely removed. It also aims to provide a reference for future changes or alternatives.

const arg = args[argument];

bench.start();
for (let iteration = 0; iteration < n; iteration++) {
func(arg);
Copy link
Copy Markdown
Member

@RafaelGSS RafaelGSS Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely being optimized.

Copy link
Copy Markdown
Member Author

@mertcanaltin mertcanaltin Dec 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I tried to fix this by using more arguments and variable arguments. 5fcf423

Comment thread
mertcanaltin marked this conversation as resolved.
Outdated
}
bench.end(n);
}
Loading