Skip to content

fix: address static analysis warnings in SQLite and WebStorage #61380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GoldFish2500 wants to merge 4 commits into
base: main
Choose a base branch
from
+9 −2
Open

fix: address static analysis warnings in SQLite and WebStorage #61380

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bad94ff
fix: address static analysis warnings in SQLite and WebStorage
GoldFish2500 Jan 14, 2026
6178b2c
throw ALLOCATION_FAILED exception. memcpy UB prevent
GoldFish2500 Apr 9, 2026
c787428
env pointer checking removed
GoldFish2500 Apr 9, 2026
550dcea
Merge branch 'main' into fix-static-analysis-warnings
GoldFish2500 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/node_sqlite.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,11 @@ using v8::Value;
case SQLITE_TEXT: { \
const char* v = \
reinterpret_cast<const char*>(sqlite3_##from##_text(__VA_ARGS__)); \
(result) = String::NewFromUtf8((isolate), v).As<Value>(); \
Copy link
Copy Markdown
Contributor

@louwers louwers Jan 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings returned by sqlite3_column_text() and sqlite3_column_text16(), even empty strings, are always zero-terminated.

If an out-of-memory error occurs, then the return value from these routines is the same as if the column had contained an SQL NULL value. Valid SQL NULL returns can be distinguished from out-of-memory errors by invoking the sqlite3_errcode() immediately after the suspect return value is obtained and before any other SQLite interface is called on the same database connection.

https://sqlite.org/c3ref/column_blob.html

If an OOM error occurs we should not just silently return null.

Copy link
Copy Markdown
Author

@GoldFish2500 GoldFish2500 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree that hiding OOM is not acceptable. I suggest throwing an appropriate exception

if (v == nullptr) { \
THROW_ERR_MEMORY_ALLOCATION_FAILED(isolate); \
} else { \
(result) = String::NewFromUtf8((isolate), v).As<Value>(); \
} \
break; \
} \
case SQLITE_NULL: { \
Expand All @@ -111,7 +115,9 @@ using v8::Value;
sqlite3_##from##_blob(__VA_ARGS__)); \
auto store = ArrayBuffer::NewBackingStore( \
(isolate), size, BackingStoreInitializationMode::kUninitialized); \
memcpy(store->Data(), data, size); \
Copy link
Copy Markdown
Author

@GoldFish2500 GoldFish2500 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding the pointer check to prevent UB. The behavior will not change, but the static analyzer will stop triggering.

if (data) { \
memcpy(store->Data(), data, size); \
} \
auto ab = ArrayBuffer::New((isolate), std::move(store)); \
(result) = Uint8Array::New(ab, 0, size); \
break; \
Expand Down Expand Up @@ -246,7 +252,7 @@ inline void THROW_ERR_SQLITE_ERROR(Isolate* isolate, int errcode) {

Environment* env = Environment::GetCurrent(isolate);
Local<Object> error;
if (CreateSQLiteError(isolate, errstr).ToLocal(&error) &&
if (env && CreateSQLiteError(isolate, errstr).ToLocal(&error) &&
Copy link
Copy Markdown
Contributor

@louwers louwers Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a problem because we assume Environment::GetCurrent(isolate) does not return null throughout the module.

Copy link
Copy Markdown
Author

@GoldFish2500 GoldFish2500 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I removed the unnecessary check.

error
->Set(isolate->GetCurrentContext(),
env->errcode_string(),
Expand Down
1 change: 1 addition & 0 deletions src/node_webstorage.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ Maybe<void> Storage::Open() {
sqlite3_stmt* s = nullptr;
r = sqlite3_prepare_v2(
db, get_schema_version_sql.data(), get_schema_version_sql.size(), &s, 0);
CHECK_ERROR_OR_THROW(env(), r, SQLITE_OK, Nothing<void>());
Copy link
Copy Markdown
Contributor

@louwers louwers Jan 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks legit.

r = sqlite3_exec(db, init_sql_v0.data(), 0, 0, nullptr);
CHECK_ERROR_OR_THROW(env(), r, SQLITE_OK, Nothing<void>());
auto stmt = stmt_unique_ptr(s);
Expand Down