Skip to content

buffer: optimize buffer.concat performance #61721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 7 commits into from
Feb 27, 2026
+50 −9
Merged

buffer: optimize buffer.concat performance #61721

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7ded458
buffer: optimize buffer.concat performance
mertcanaltin Feb 7, 2026
a7fd75d
revert comment lines
mertcanaltin Feb 7, 2026
885c7a3
revert comment lines
mertcanaltin Feb 7, 2026
ba806ae
revert listLen caching
mertcanaltin Feb 7, 2026
559f5e9
move type validation before allocation
mertcanaltin Feb 7, 2026
1898304
use TypedArrayPrototypeGetByteLength
mertcanaltin Feb 8, 2026
4848305
add test for spoofed length getter in concat
mertcanaltin Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 37 additions & 9 deletions lib/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,25 +614,53 @@ Buffer.concat = function concat(list, length) {
if (length === undefined) {
length = 0;
for (let i = 0; i < list.length; i++) {
if (list[i].length) {
length += list[i].length;
const buf = list[i];
if (!isUint8Array(buf)) {
// TODO(BridgeAR): This should not be of type ERR_INVALID_ARG_TYPE.
// Instead, find the proper error code for this.
throw new ERR_INVALID_ARG_TYPE(
`list[${i}]`, ['Buffer', 'Uint8Array'], buf);
}
Comment thread
gurgunday marked this conversation as resolved.
length += buf.length;
Comment thread
mertcanaltin marked this conversation as resolved.
Outdated
}
} else {
validateOffset(length, 'length');

const buffer = allocate(length);
let pos = 0;
for (let i = 0; i < list.length; i++) {
const buf = list[i];
TypedArrayPrototypeSet(buffer, buf, pos);
pos += buf.length;
}

if (pos < length) {
TypedArrayPrototypeFill(buffer, 0, pos, length);
}
Comment thread
mertcanaltin marked this conversation as resolved.
Comment thread
mertcanaltin marked this conversation as resolved.
return buffer;
}

const buffer = Buffer.allocUnsafe(length);
let pos = 0;
validateOffset(length, 'length');
for (let i = 0; i < list.length; i++) {
const buf = list[i];
if (!isUint8Array(buf)) {
if (!isUint8Array(list[i])) {
// TODO(BridgeAR): This should not be of type ERR_INVALID_ARG_TYPE.
// Instead, find the proper error code for this.
throw new ERR_INVALID_ARG_TYPE(
`list[${i}]`, ['Buffer', 'Uint8Array'], list[i]);
}
pos += _copyActual(buf, buffer, pos, 0, buf.length, true);
}

const buffer = allocate(length);
let pos = 0;
for (let i = 0; i < list.length; i++) {
const buf = list[i];
if (pos + buf.length > length) {
TypedArrayPrototypeSet(buffer,
TypedArrayPrototypeSlice(buf, 0, length - pos),
Comment thread
mertcanaltin marked this conversation as resolved.
Outdated
pos);
pos = length;
break;
}
TypedArrayPrototypeSet(buffer, buf, pos);
pos += buf.length;
}

// Note: `length` is always equal to `buffer.length` at this point
Expand Down
Loading