Skip to content

stream: fix decoded fromList chunk boundary check #61884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Feb 22, 2026
+17 −1
Merged

stream: fix decoded fromList chunk boundary check #61884

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ef134f
stream: fix decoded fromList chunk boundary check
watson Feb 19, 2026
2984f13
fix lint
watson Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/streams/readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1669,7 +1669,7 @@ function fromList(n, state) {
n -= str.length;
buf[idx++] = null;
} else {
if (n === buf.length) {
if (n === str.length) {
ret += str;
buf[idx++] = null;
} else {
Expand Down
15 changes: 15 additions & 0 deletions test/parallel/test-stream2-read-correct-num-bytes-in-utf8.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
'use strict';

Check failure on line 1 in test/parallel/test-stream2-read-correct-num-bytes-in-utf8.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Mandatory module "common" must be loaded before any other modules

Check failure on line 1 in test/parallel/test-stream2-read-correct-num-bytes-in-utf8.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Mandatory module "common" must be loaded

const assert = require('assert');
const { Readable } = require('stream');

const readable = new Readable({ read() {} });
readable.setEncoding('utf8');

readable.push('abc');
readable.push('defgh');
readable.push(null);

assert.strictEqual(readable.read(5), 'abcde');
assert.strictEqual(readable.read(3), 'fgh');
assert.strictEqual(readable.read(1), null);
Loading