inspector: auto collect webstorage data by islandryu · Pull Request #62145 · nodejs/node

islandryu · 2026-03-07T10:24:08Z

Web Storage data collection, which previously required explicitly firing events to send data to DevTools, is now performed automatically within Node.js.
Web Storage will appear in DevTools simply by specifying --experimental-storage-inspection, without requiring any code changes.

This feature relies on the changes introduced in the following change request, so it can be verified with the latest DevTools commit:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7274801

nodejs-github-bot · 2026-03-07T10:24:12Z

Review requested:

@nodejs/inspector

codecov · 2026-03-07T11:46:55Z

Codecov Report

❌ Patch coverage is 93.71728% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (a6e9e32) to head (57f5b49).
⚠️ Report is 244 commits behind head on main.

Files with missing lines	Patch %	Lines
src/inspector/dom_storage_agent.cc	82.05%	1 Missing and 6 partials ⚠️
src/node_webstorage.cc	77.27%	1 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62145      +/-   ##
==========================================
+ Coverage   89.64%   89.69%   +0.04%     
==========================================
  Files         676      677       +1     
  Lines      206240   206871     +631     
  Branches    39514    39618     +104     
==========================================
+ Hits       184891   185544     +653     
+ Misses      13465    13451      -14     
+ Partials     7884     7876       -8

Files with missing lines	Coverage Δ
lib/internal/inspector/webstorage.js	`100.00% <100.00%> (ø)`
lib/internal/webstorage.js	`100.00% <100.00%> (ø)`
src/node_builtins.cc	`75.95% <ø> (ø)`
src/node_webstorage.h	`83.33% <ø> (ø)`
src/node_webstorage.cc	`74.81% <77.27%> (+0.07%)`	⬆️
src/inspector/dom_storage_agent.cc	`67.74% <82.05%> (+18.06%)`	⬆️

... and 102 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

addaleax

Looks good!

I'd still recommend adding a test for UTF-16 characters outside the ISO-8859-1 range (e.g. emoji or Chinese characters)

github-actions · 2026-03-08T12:18:53Z

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✘  Failed to start PR CI: 404 Not Found

https://github.com/nodejs/node/actions/runs/22820941170

aduh95 · 2026-03-08T18:58:09Z

Related test failure:

Path: parallel/test-code-cache
Error: --- stderr ---
node:internal/bootstrap/realm:185
      mod = bindingObj[module] = getInternalBinding(module);
                                 ^

Error: No such binding: webstorage

You probably need to skip that test when compiled without SQLite

islandryu · 2026-03-09T04:35:45Z

I changed the implementation to handle the storage keys and values as UTF-16.

nodejs-github-bot · 2026-03-09T10:56:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71616/

nodejs-github-bot · 2026-03-10T06:21:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71648/

addaleax · 2026-03-10T13:11:58Z

-      is_local_storage ? local_storage_map_ : session_storage_map_;
+  std::optional<StorageMap> storage_map =
+      is_local_storage ? std::make_optional<StorageMap>(local_storage_map_)
+                       : std::make_optional<StorageMap>(session_storage_map_);


This is still making full copies – that's proably fine for a inspector feature, but it's an unnecessary set of extra allocations

nodejs-github-bot · 2026-03-10T13:41:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71656/

nodejs-github-bot · 2026-03-11T14:16:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71693/

Co-authored-by: Anna Henningsen <github@addaleax.net>

nodejs-github-bot · 2026-03-28T03:43:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72126/

nodejs-github-bot · 2026-03-28T08:22:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72134/

nodejs-github-bot · 2026-03-28T09:08:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72135/

nodejs-github-bot · 2026-03-31T20:32:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72367/

nodejs-github-bot · 2026-04-04T12:48:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72466/

nodejs-github-bot · 2026-04-05T00:42:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72474/

nodejs-github-bot · 2026-04-05T01:42:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72476/

nodejs-github-bot · 2026-04-05T01:51:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72477/

nodejs-github-bot · 2026-04-05T02:01:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72478/

nodejs-github-bot · 2026-04-05T02:38:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72479/

nodejs-github-bot · 2026-04-05T02:50:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72480/

nodejs-github-bot · 2026-04-05T23:22:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72497/

nodejs-github-bot · 2026-04-06T08:17:57Z

Landed in d93935b

Signed-off-by: Ali Hassan <ali-hassan27@outlook.com> PR-URL: #62616 Refs: #62145 Refs: #62162 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

inspector: auto collect webstorage data

1e514ca

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 7, 2026

addaleax requested changes Mar 8, 2026

View reviewed changes

Comment thread src/inspector/dom_storage_agent.cc Outdated

Comment thread src/inspector/dom_storage_agent.cc Outdated

Comment thread src/inspector/dom_storage_agent.cc

Comment thread src/node_webstorage.cc Outdated

Comment thread src/node_webstorage.cc Outdated

fix review

d897bd3

addaleax approved these changes Mar 8, 2026

View reviewed changes

addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 8, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 8, 2026

ryuhei shima added 2 commits March 9, 2026 12:58

support utf16

5c82977

skip test if SQLite missinig

3a72667

islandryu force-pushed the autoCollectWebStorage branch from 8e0c41b to b278ecc Compare March 9, 2026 04:34

lint

8fc09a7

islandryu force-pushed the autoCollectWebStorage branch from b278ecc to 8fc09a7 Compare March 9, 2026 05:21

fix No such binding

5debe1c

addaleax reviewed Mar 9, 2026

View reviewed changes

Comment thread src/inspector/dom_storage_agent.cc Outdated

Renegade334 removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Mar 10, 2026

addaleax approved these changes Mar 10, 2026

View reviewed changes

addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2026

addaleax approved these changes Mar 20, 2026

View reviewed changes

Comment thread src/inspector/dom_storage_agent.cc Outdated

Update src/inspector/dom_storage_agent.cc

57f5b49

Co-authored-by: Anna Henningsen <github@addaleax.net>

addaleax approved these changes Mar 21, 2026

View reviewed changes

addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 21, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2026

This comment was marked as outdated.

Sign in to view

legendecas approved these changes Mar 26, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

islandryu added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 6, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 6, 2026

nodejs-github-bot merged commit d93935b into nodejs:main Apr 6, 2026
75 checks passed

thisalihassan mentioned this pull request Apr 6, 2026

inspector: coerce key and value to string in webstorage events #62616

Closed

Han5991 mentioned this pull request Apr 6, 2026

stream: fix writev unhandled rejection in fromWeb #62297

Merged

Uh oh!

Conversation

islandryu commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 7, 2026

Uh oh!

codecov bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

aduh95 commented Mar 8, 2026

Uh oh!

islandryu commented Mar 9, 2026

Uh oh!

nodejs-github-bot commented Mar 9, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 10, 2026

Uh oh!

addaleax Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 10, 2026

Uh oh!

nodejs-github-bot commented Mar 11, 2026

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Mar 28, 2026

Uh oh!

nodejs-github-bot commented Mar 28, 2026

Uh oh!

nodejs-github-bot commented Mar 28, 2026

Uh oh!

nodejs-github-bot commented Mar 31, 2026

Uh oh!

nodejs-github-bot commented Apr 4, 2026

Uh oh!

nodejs-github-bot commented Apr 5, 2026

Uh oh!

nodejs-github-bot commented Apr 5, 2026

Uh oh!

nodejs-github-bot commented Apr 5, 2026

Uh oh!

nodejs-github-bot commented Apr 5, 2026

Uh oh!

nodejs-github-bot commented Apr 5, 2026

Uh oh!

nodejs-github-bot commented Apr 5, 2026

Uh oh!

nodejs-github-bot commented Apr 5, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

islandryu commented Mar 7, 2026 •

edited

Loading

codecov bot commented Mar 7, 2026 •

edited

Loading