Skip to content

tools: do not swallow error in lint-nix workflow #62292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Mar 19, 2026
+6 −1
Merged

tools: do not swallow error in lint-nix workflow #62292

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1610d85
tools: do not swallow error in `lint-nix` workflow
aduh95 Mar 17, 2026
0404f0b
fixup! tools: do not swallow error in `lint-nix` workflow
aduh95 Mar 17, 2026
b67d1dd
fixup! tools: do not swallow error in `lint-nix` workflow
aduh95 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/linters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,13 @@ jobs:
sparse-checkout-cone-mode: false
- uses: cachix/install-nix-action@2126ae7fc54c9df00dd18f7f18754393182c73cd # v31.9.1
- name: Lint Nix files
id: lint-step
run: |
nix-shell -I nixpkgs=./tools/nix/pkgs.nix -p 'nixfmt-tree' --run '
treefmt --quiet --ci
' || git --no-pager diff --exit-code
'
- run: git --no-pager diff
if: ${{ failure() && steps.lint-step.conclusion == 'failure' }}
Comment thread
aduh95 marked this conversation as resolved.
Outdated

lint-py:
if: github.event.pull_request.draft == false
Expand Down