tools: fix redundant conditions in v8.gyp for riscv64 and loong64#62608
Open
JamieMagee wants to merge 1 commit intonodejs:mainfrom
Open
tools: fix redundant conditions in v8.gyp for riscv64 and loong64#62608JamieMagee wants to merge 1 commit intonodejs:mainfrom
JamieMagee wants to merge 1 commit intonodejs:mainfrom
Conversation
The builtins conditions for riscv64 and loong64 both have the form 'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant. This was copied from the mips64/mips64el pattern (where the 'or' is correct since those are two different architectures) when riscv64 and loong64 support were first added. Simplify both to match the pattern used by ppc64, s390x, and other single-variant architectures. Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
cjihrig
approved these changes
Apr 5, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The builtins conditions for riscv64 and loong64 both read
v8_target_arch=="X" or v8_target_arch=="X". The same value on both sides of theor. This was copied from themips64 or mips64elpattern when riscv64 (#37980) and loong64 support were first added, but those are two different architectures and riscv64/loong64 each only have one.Simplify both to plain
v8_target_arch=="riscv64"/v8_target_arch=="loong64", matching ppc64, s390x, and the other single-variant architectures.