Skip to content

quic: implement multiple c++ side improvements#62620

Open
jasnell wants to merge 5 commits intonodejs:mainfrom
jasnell:jasnell/quic-tlscontext-improvements
Open

quic: implement multiple c++ side improvements#62620
jasnell wants to merge 5 commits intonodejs:mainfrom
jasnell:jasnell/quic-tlscontext-improvements

Conversation

@jasnell
Copy link
Copy Markdown
Member

@jasnell jasnell commented Apr 6, 2026

Further QUIC c++ side improvements supporting proper SNI handling, multi-ALPN negotiation on the server-side, hash performance/strength improvements, and some bug fixes.

Signed-off-by: James M Snell jasnell@gmail.com
Assisted-by: Opencode:Opus 4.6

jasnell added 4 commits April 6, 2026 13:55
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode:Opus 4.6
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode:Opus 4.6
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode:Opus 4.6
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode:Opus 4.6
@jasnell jasnell requested review from Qard and mcollina April 6, 2026 21:20
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 6, 2026
@jasnell jasnell changed the title quic: implement rapidhash for hashing improvements quic: implement multiple c++ side improvements Apr 6, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 83.15789% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.76%. Comparing base (449a93a) to head (6293e87).

Files with missing lines Patch % Lines
src/node_hash.h 46.34% 40 Missing and 4 partials ⚠️
lib/internal/quic/state.js 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62620      +/-   ##
==========================================
- Coverage   89.78%   89.76%   -0.02%     
==========================================
  Files         697      698       +1     
  Lines      215749   215964     +215     
  Branches    41294    41299       +5     
==========================================
+ Hits       193705   193870     +165     
- Misses      14124    14164      +40     
- Partials     7920     7930      +10     
Files with missing lines Coverage Δ
lib/internal/quic/quic.js 100.00% <100.00%> (ø)
lib/internal/quic/symbols.js 100.00% <ø> (ø)
src/node_sockaddr-inl.h 90.09% <ø> (-0.43%) ⬇️
src/node_sockaddr.cc 71.18% <100.00%> (-0.06%) ⬇️
lib/internal/quic/state.js 51.79% <55.55%> (+0.05%) ⬆️
src/node_hash.h 46.34% <46.34%> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants