Skip to content

crypto: guard against size_t overflow on experimental 32-bit arch#62626

Open
panva wants to merge 1 commit intonodejs:mainfrom
panva:fail-fast-32bit-overflow
Open

crypto: guard against size_t overflow on experimental 32-bit arch#62626
panva wants to merge 1 commit intonodejs:mainfrom
panva:fail-fast-32bit-overflow

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Apr 7, 2026

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 7, 2026
@panva panva requested a review from RafaelGSS April 7, 2026 16:30
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2026
@panva
Copy link
Copy Markdown
Member Author

panva commented Apr 7, 2026

cc @nodejs/security

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.77%. Comparing base (f48ac91) to head (a6bedb1).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_turboshake.cc 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #62626   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files         697      697           
  Lines      215749   215754    +5     
  Branches    41304    41288   -16     
=======================================
+ Hits       193681   193698   +17     
- Misses      14161    14166    +5     
+ Partials     7907     7890   -17     
Files with missing lines Coverage Δ
src/crypto/crypto_turboshake.cc 82.81% <40.00%> (-0.62%) ⬇️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants