Skip to content

diagnostics_channel: specialized tracing channels#62641

Draft
Qard wants to merge 1 commit intonodejs:mainfrom
Qard:tracing-channel-specializations
Draft

diagnostics_channel: specialized tracing channels#62641
Qard wants to merge 1 commit intonodejs:mainfrom
Qard:tracing-channel-specializations

Conversation

@Qard
Copy link
Copy Markdown
Member

@Qard Qard commented Apr 9, 2026

This is still a work-in-progress, but I want to share this before the collab summit so people can see the direction I'm trying to go with this and think about it for the upcoming session on these and other Observability changes I'm working on.

The general idea is that TracingChannel having sync, callback, and promise trace functions was a bit inflexible. What I'm going for here is to split apart concerns into three tracing categories: calls, parameter mapping for callbacks, and return value mapping for promises and iterators.

I'll continue working on this, and especially improving the docs to explain these concepts in more detail.

cc @nodejs/diagnostics

@Qard Qard self-assigned this Apr 9, 2026
@Qard Qard added the diagnostics_channel Issues and PRs related to diagnostics channel label Apr 9, 2026
@Qard Qard marked this pull request as draft April 9, 2026 00:32
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 95.97990% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (bf1aebc) to head (1597d07).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
lib/diagnostics_channel.js 95.97% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62641      +/-   ##
==========================================
+ Coverage   89.72%   89.80%   +0.08%     
==========================================
  Files         695      697       +2     
  Lines      214464   216293    +1829     
  Branches    41067    41405     +338     
==========================================
+ Hits       192420   194251    +1831     
- Misses      14106    14135      +29     
+ Partials     7938     7907      -31     
Files with missing lines Coverage Δ
lib/diagnostics_channel.js 96.90% <95.97%> (-1.23%) ⬇️

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diagnostics_channel Issues and PRs related to diagnostics channel needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants