test: generate localstorage-file in a temp dir

eslint.config.mjs

@@ -70,6 +70,7 @@ export default [
       // Filtering tsc output files (i.e. if there a foo.ts, we ignore foo.js):
       (f, _, files) => f.endsWith('js') && files.includes(f.replace(/(\.[cm]?)js$/, '$1ts')),
     ),
+    '!test/fixtures/test-inspector-dom-storage.mjs',
     '!test/fixtures/test-runner',
     'test/fixtures/test-runner/*',
     '!test/fixtures/test-runner/output',

test/fixtures/test-inspector-dom-storage.mjs

@@ -0,0 +1,151 @@
+import * as common from '../common/index.mjs';
+import assert from 'assert';
+import { DOMStorage, Session } from 'node:inspector/promises';
+import { pathToFileURL } from 'node:url';
+import path from 'node:path';
+import process from 'node:process';
+
+{
+  const session = new Session();
+  await session.connect();
+
+  await session.post('DOMStorage.enable');
+
+  const localStorageFileUrl =
+    pathToFileURL(path.join(process.cwd(), 'localstorage.db')).href;
+
+  const { storageKey } = await session.post('Storage.getStorageKey');
+  assert.strictEqual(
+    storageKey.toLowerCase(),
+    localStorageFileUrl.toLowerCase(),
+  );
+
+  for (const isLocalStorage of [true, false]) {
+    DOMStorage.registerStorage({
+      isLocalStorage,
+      storageMap: {
+        key1: 'value1',
+        key2: 'value2',
+        [1]: 2,
+        [true]: 'booleanKey',
+        ['ключ']: 'значение',
+      },
+    });
+    const result = await session.post('DOMStorage.getDOMStorageItems', {
+      storageId: {
+        isLocalStorage,
+        securityOrigin: 'node-inspector://default-dom-storage',
+      },
+    });
+    const sortedEntries = result.entries.sort((a, b) =>
+      a[0].localeCompare(b[0]),
+    );
+    assert.deepStrictEqual(sortedEntries, [
+      ['1', '2'],
+      ['key1', 'value1'],
+      ['key2', 'value2'],
+      ['true', 'booleanKey'],
+      ['ключ', 'значение'],
+    ]);
+  }
+  session.disconnect();
+}
+
+{
+  for (const isLocalStorage of [true, false]) {
+    const webStorage = isLocalStorage ? localStorage : sessionStorage;
+    const session = new Session();
+    webStorage.clear();
+    await session.connect();
+
+    const storageKey = await session.post('Storage.getStorageKey');
+    await session.post('DOMStorage.enable');
+
+    webStorage.setItem('key1', 'value');
+    webStorage.setItem('key2', 1);
+    webStorage.setItem('key3', JSON.stringify({ a: 1 }));
+    webStorage.setItem('ключ', 'значение');
+
+    const result = await session.post('DOMStorage.getDOMStorageItems', {
+      storageId: {
+        isLocalStorage,
+        securityOrigin: '',
+        storageKey: storageKey.storageKey,
+      },
+    });
+    assert.strictEqual(result.entries.length, 4);
+    const entries = Object.fromEntries(result.entries);
+    assert.strictEqual(entries.key1, 'value');
+    assert.strictEqual(entries.key2, '1');
+    assert.strictEqual(entries.key3, JSON.stringify({ a: 1 }));
+    assert.strictEqual(entries['ключ'], 'значение');
+    session.disconnect();
+  }
+}
+
+{
+  for (const isLocalStorage of [true, false]) {
+    const webStorage = isLocalStorage ? localStorage : sessionStorage;
+    webStorage.clear();
+    const session = new Session();
+    await session.connect();
+    await session.post('DOMStorage.enable');
+    const storageKey = await session.post('Storage.getStorageKey');
+    session.on(
+      'DOMStorage.domStorageItemAdded',
+      common.mustCall(({ params }) => {
+        assert.strictEqual(params.key, 'key');
+        assert.strictEqual(params.newValue, 'value');
+        assert.deepStrictEqual(params.storageId, {
+          securityOrigin: '',
+          isLocalStorage,
+          storageKey: storageKey.storageKey,
+        });
+      }),
+    );
+    webStorage.setItem('key', 'value');
+
+    session.on(
+      'DOMStorage.domStorageItemUpdated',
+      common.mustCall(({ params }) => {
+        assert.strictEqual(params.key, 'key');
+        assert.strictEqual(params.oldValue, 'value');
+        assert.strictEqual(params.newValue, 'newValue');
+        assert.deepStrictEqual(params.storageId, {
+          securityOrigin: '',
+          isLocalStorage,
+          storageKey: storageKey.storageKey,
+        });
+      }),
+    );
+
+    webStorage.setItem('key', 'newValue');
+
+    session.on(
+      'DOMStorage.domStorageItemRemoved',
+      common.mustCall(({ params }) => {
+        assert.strictEqual(params.key, 'key');
+        assert.deepStrictEqual(params.storageId, {
+          securityOrigin: '',
+          isLocalStorage,
+          storageKey: storageKey.storageKey,
+        });
+      }),
+    );
+
+    webStorage.removeItem('key');
+
+    session.on(
+      'DOMStorage.domStorageItemsCleared',
+      common.mustCall(({ params }) => {
+        assert.deepStrictEqual(params.storageId, {
+          securityOrigin: '',
+          isLocalStorage,
+          storageKey: storageKey.storageKey,
+        });
+      }),
+    );
+    webStorage.clear();
+    session.disconnect();
+  }
+}

test/parallel/test-inspector-dom-storage.js

@@ -1,170 +1,16 @@
-// Flags: --inspect=0 --experimental-storage-inspection --localstorage-file=./localstorage.db
 'use strict';
 
 const common = require('../common');
-const assert = require('assert');
 common.skipIfSQLiteMissing();
 common.skipIfInspectorDisabled();
-const { DOMStorage, Session } = require('node:inspector/promises');
-const { pathToFileURL } = require('node:url');
-const path = require('node:path');
-
-async function testRegisterStorage() {
-  const session = new Session();
-  await session.connect();
-
-  await session.post('DOMStorage.enable');
-
-  const localStorageFileUrl =
-    pathToFileURL(path.join(process.cwd(), 'localstorage.db')).href;
-
-  const { storageKey } = await session.post('Storage.getStorageKey');
-  assert.strictEqual(
-    storageKey.toLowerCase(),
-    localStorageFileUrl.toLowerCase()
-  );
-
-  await checkStorage(true);
-  await checkStorage(false);
-  session.disconnect();
-
-  async function checkStorage(isLocalStorage) {
-    DOMStorage.registerStorage({
-      isLocalStorage,
-      storageMap: {
-        key1: 'value1',
-        key2: 'value2',
-        [1]: 2,
-        [true]: 'booleanKey',
-        ['ключ']: 'значение',
-      },
-    });
-    const result = await session.post('DOMStorage.getDOMStorageItems', {
-      storageId: {
-        isLocalStorage,
-        securityOrigin: 'node-inspector://default-dom-storage',
-      },
-    });
-    const sortedEntries = result.entries.sort((a, b) =>
-      a[0].localeCompare(b[0]),
-    );
-    assert.deepStrictEqual(sortedEntries, [
-      ['1', '2'],
-      ['key1', 'value1'],
-      ['key2', 'value2'],
-      ['true', 'booleanKey'],
-      ['ключ', 'значение'],
-    ]);
-  }
-}
-
-async function testGetData() {
-  await test(true);
-  await test(false);
-
-  async function test(isLocalStorage) {
-    const webStorage = isLocalStorage ? localStorage : sessionStorage;
-    const session = new Session();
-    webStorage.clear();
-    await session.connect();
-
-    const storageKey = await session.post('Storage.getStorageKey');
-    await session.post('DOMStorage.enable');
-
-    webStorage.setItem('key1', 'value');
-    webStorage.setItem('key2', 1);
-    webStorage.setItem('key3', JSON.stringify({ a: 1 }));
-    webStorage.setItem('ключ', 'значение');
-
-    const result = await session.post('DOMStorage.getDOMStorageItems', {
-      storageId: {
-        isLocalStorage,
-        securityOrigin: '',
-        storageKey: storageKey.storageKey,
-      },
-    });
-    assert.strictEqual(result.entries.length, 4);
-    const entries = Object.fromEntries(result.entries);
-    assert.strictEqual(entries.key1, 'value');
-    assert.strictEqual(entries.key2, '1');
-    assert.strictEqual(entries.key3, JSON.stringify({ a: 1 }));
-    assert.strictEqual(entries['ключ'], 'значение');
-    session.disconnect();
-  }
-}
-
-async function testEvents() {
-  await test(true);
-  await test(false);
-  async function test(isLocalStorage) {
-    const webStorage = isLocalStorage ? localStorage : sessionStorage;
-    webStorage.clear();
-    const session = new Session();
-    await session.connect();
-    await session.post('DOMStorage.enable');
-    const storageKey = await session.post('Storage.getStorageKey');
-    session.on(
-      'DOMStorage.domStorageItemAdded',
-      common.mustCall(({ params }) => {
-        assert.strictEqual(params.key, 'key');
-        assert.strictEqual(params.newValue, 'value');
-        assert.deepStrictEqual(params.storageId, {
-          securityOrigin: '',
-          isLocalStorage,
-          storageKey: storageKey.storageKey,
-        });
-      }),
-    );
-    webStorage.setItem('key', 'value');
-
-    session.on(
-      'DOMStorage.domStorageItemUpdated',
-      common.mustCall(({ params }) => {
-        assert.strictEqual(params.key, 'key');
-        assert.strictEqual(params.oldValue, 'value');
-        assert.strictEqual(params.newValue, 'newValue');
-        assert.deepStrictEqual(params.storageId, {
-          securityOrigin: '',
-          isLocalStorage,
-          storageKey: storageKey.storageKey,
-        });
-      }),
-    );
-
-    webStorage.setItem('key', 'newValue');
-
-    session.on(
-      'DOMStorage.domStorageItemRemoved',
-      common.mustCall(({ params }) => {
-        assert.strictEqual(params.key, 'key');
-        assert.deepStrictEqual(params.storageId, {
-          securityOrigin: '',
-          isLocalStorage,
-          storageKey: storageKey.storageKey,
-        });
-      }),
-    );
-
-    webStorage.removeItem('key');
-
-    session.on(
-      'DOMStorage.domStorageItemsCleared',
-      common.mustCall(({ params }) => {
-        assert.deepStrictEqual(params.storageId, {
-          securityOrigin: '',
-          isLocalStorage,
-          storageKey: storageKey.storageKey,
-        });
-      }),
-    );
-    webStorage.clear();
-    session.disconnect();
-  }
-}
-
-async function test() {
-  await testRegisterStorage();
-  await testGetData();
-  await testEvents();
-}
-test().then(common.mustCall());
+const { spawnSyncAndExitWithoutError } = require('../common/child_process');
+const fixtures = require('../common/fixtures');
+const tmpdir = require('../common/tmpdir');
+tmpdir.refresh();
+
+spawnSyncAndExitWithoutError(process.execPath, [
+  '--inspect=0',
+  '--experimental-storage-inspection',
+  '--localstorage-file=./localstorage.db',
+  fixtures.path('test-inspector-dom-storage.mjs'),
+], { cwd: tmpdir.path });