Skip to content

deps: fix ast-value-factory build without shared RO heap #62664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaveT1991 wants to merge 1 commit into
base: v22.x-staging
Choose a base branch
from
Open

deps: fix ast-value-factory build without shared RO heap #62664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions deps/v8/src/ast/ast-value-factory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
#include "src/common/globals.h"
#include "src/heap/factory-inl.h"
#include "src/heap/local-factory-inl.h"
#include "src/objects/string.h"
#include "src/objects/string-inl.h"
#include "src/roots/roots.h"
#include "src/strings/string-hasher.h"
#include "src/utils/utils-inl.h"

Expand Down Expand Up @@ -83,7 +84,7 @@ bool AstRawString::AsArrayIndex(uint32_t* index) const {
if (!IsIntegerIndex()) return false;
if (length() <= Name::kMaxCachedArrayIndexLength) {
*index = StringHasher::DecodeArrayIndexFromHashField(
raw_hash_field_, HashSeed(ReadOnlyHeap::GetReadOnlyRoots()));
raw_hash_field_, HashSeed(GetReadOnlyRoots()));
return true;
}
// Might be an index, but too big to cache it. Do the slow conversion. This
Expand Down
Loading