Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
geeksilva97
force-pushed
the
refactor-sqlite-backup-job
branch
from
62cbb93 to
6c11173
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62732 +/- ##
==========================================
+ Coverage 88.52% 89.69% +1.16%
==========================================
Files 704 706 +2
Lines 208863 218264 +9401
Branches 40335 41785 +1450
==========================================
+ Hits 184905 195769 +10864
+ Misses 15928 14397 -1531
- Partials 8030 8098 +68
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
I think this is a use-after-erase, Finalize() now calls source_->RemoveBackup(this) at the bottom, which does backups_.erase(this)
Contributor
Author
There was a problem hiding this comment.
good catch. will fix it
geeksilva97
force-pushed
the
refactor-sqlite-backup-job
branch
from
6c11173 to
6bf17f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves code of BackupJob class in sqlite codebase.