Skip to content

test: skip test-temporal-with-zoneinfo on system-icu builds #62754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aduh95 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

test: skip test-temporal-with-zoneinfo on system-icu builds #62754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2388,6 +2388,7 @@ def icu_download(path):

# always set icu_small, node.gyp depends on it being defined.
o['variables']['icu_small'] = b(False)
o['variables']['icu_system'] = b(False)

# prevent data override
o['defines'] += ['ICU_NO_USER_DATA_OVERRIDE']
Expand Down Expand Up @@ -2424,6 +2425,7 @@ def icu_download(path):
o['variables']['v8_enable_i18n_support'] = 1
elif with_intl == 'system-icu':
# ICU from pkg-config.
o['variables']['icu_system'] = b(True)
o['variables']['v8_enable_i18n_support'] = 1
pkgicu = pkg_config(['icu-i18n', 'icu-uc'])
if not pkgicu[0]:
Expand Down
4 changes: 4 additions & 0 deletions test/parallel/test-temporal-with-zoneinfo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ if (!process.config.variables.v8_enable_temporal_support) {
if (!common.hasFullICU) {
common.skip('Time zone support unavailable when not built with full ICU');
}
// TODO(aduh95): fix zoneinfo support with system-icu.
if (process.config.variables.icu_system) {
common.skip('Time zone support unavailable on --with-intl=system-icu builds');
}

// Use globalThis.Temporal to workaround linter complaints.
assert.strictEqual(typeof globalThis.Temporal, 'object');
Expand Down
Loading