test: migrate console_assert message test to snapshot#62801
Open
galaxy4276 wants to merge 1 commit intonodejs:mainfrom
Open
test: migrate console_assert message test to snapshot#62801galaxy4276 wants to merge 1 commit intonodejs:mainfrom
galaxy4276 wants to merge 1 commit intonodejs:mainfrom
Conversation
Migrate test/message/console_assert from the legacy Python-based
test runner to the JS snapshot approach used by
test-node-output-console.mjs.
The new fixture runs console.assert(false, Symbol('hello')) and
compares against a snapshot, removing the dependency on testcfg.py
and the .out file pattern.
Refs: nodejs#47707
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nodejs-github-bot
added
needs-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
test/message/console_assertfrom the legacy Python-based test runner (testcfg.py+.outfile) to the modern JS snapshot approach.Changes
test/fixtures/console/console_assert.js— the fixture script(same logic as the old
test/message/console_assert.js, with therequirepath adjusted for the new location)test/fixtures/console/console_assert.snapshot— expected outputconsole/console_assert.jsentry totest-node-output-console.mjstest/message/console_assert.jsandtest/message/console_assert.outWhat the test verifies
console.assert(false, Symbol('hello'))should printAssertion failed Symbol(hello)to stderr without throwing or exiting.The snapshot captures this expected output.
Refs: #47707
Test plan
node --test test/parallel/test-node-output-console.mjspassestest/message/tests affected