test: update expectations for OpenSSL 3.6 and OpenSSL 4.0#62805
Open
panva wants to merge 8 commits intonodejs:mainfrom
Open
test: update expectations for OpenSSL 3.6 and OpenSSL 4.0#62805panva wants to merge 8 commits intonodejs:mainfrom
panva wants to merge 8 commits intonodejs:mainfrom
Conversation
TLS_server_method() was added in OpenSSL 1.1.0. All version-specific methods were deprecated in OpenSSL 1.1.0. All version-specific methods were removed in OpenSSL 4.0. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
added
tls
nodejs-github-bot
added
addons
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62805 +/- ##
==========================================
- Coverage 89.69% 89.67% -0.03%
==========================================
Files 706 706
Lines 218270 218288 +18
Branches 41782 41775 -7
==========================================
- Hits 195786 195758 -28
- Misses 14390 14446 +56
+ Partials 8094 8084 -10 🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
panva
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Member
Author
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
approved these changes
Apr 18, 2026
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
I can confirm it does fix #60088
I was not able to build with OpenSSL 4.0.0 (error below) but that's not related to this PR, I'm getting the same on main.
Details
Undefined symbols for architecture arm64:
"_ENGINE_by_id", referenced from:
ncrypto::EnginePointer::getEngineByName(char const*, ncrypto::CryptoErrorList*) in libncrypto.a(ncrypto.engine.o)
"_ENGINE_ctrl_cmd_string", referenced from:
ncrypto::EnginePointer::getEngineByName(char const*, ncrypto::CryptoErrorList*) in libncrypto.a(ncrypto.engine.o)
"_ENGINE_finish", referenced from:
ncrypto::EnginePointer::~EnginePointer() in libncrypto.a(ncrypto.engine.o)
ncrypto::EnginePointer::reset(engine_st*, bool) in libncrypto.a(ncrypto.engine.o)
ncrypto::EnginePointer::~EnginePointer() in libncrypto.a(ncrypto.engine.o)
ncrypto::EnginePointer::operator=(ncrypto::EnginePointer&&) in libncrypto.a(ncrypto.engine.o)
"_ENGINE_free", referenced from:
ncrypto::EnginePointer::~EnginePointer() in libncrypto.a(ncrypto.engine.o)
ncrypto::EnginePointer::reset(engine_st*, bool) in libncrypto.a(ncrypto.engine.o)
ncrypto::EnginePointer::~EnginePointer() in libncrypto.a(ncrypto.engine.o)
ncrypto::EnginePointer::operator=(ncrypto::EnginePointer&&) in libncrypto.a(ncrypto.engine.o)
ncrypto::EnginePointer::getEngineByName(char const*, ncrypto::CryptoErrorList*) in libncrypto.a(ncrypto.engine.o)
"_ENGINE_init", referenced from:
ncrypto::EnginePointer::init(bool) in libncrypto.a(ncrypto.engine.o)
"_ENGINE_load_builtin_engines", referenced from:
ncrypto::EnginePointer::initEnginesOnce() in libncrypto.a(ncrypto.engine.o)
"_ENGINE_load_private_key", referenced from:
ncrypto::EnginePointer::loadPrivateKey(char const*) in libncrypto.a(ncrypto.engine.o)
"_ENGINE_register_all_complete", referenced from:
ncrypto::EnginePointer::initEnginesOnce() in libncrypto.a(ncrypto.engine.o)
"_ENGINE_set_default", referenced from:
ncrypto::EnginePointer::setAsDefault(unsigned int, ncrypto::CryptoErrorList*) in libncrypto.a(ncrypto.engine.o)
"_SSL_CTX_set_client_cert_engine", referenced from:
node::crypto::SecureContext::SetClientCertEngine(v8::FunctionCallbackInfo<v8::Value> const&) in libnode.a(libnode.crypto_context.o)
ld: symbol(s) not found for architecture arm64
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #62410, this PR updates test expectations for OpenSSL 4.0 (and in one case for OpenSSL 3.6).
Tested with a temporary shared openssl workflow in #62799 (https://github.com/nodejs/node/actions/runs/24604775004)
Closes #62799
Closes #60088