test_runner: fix suite rerun edge case#62860
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 23, 2026
Merged
Conversation
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
atlowChemi
approved these changes
Apr 21, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62860 +/- ##
==========================================
+ Coverage 89.62% 89.63% +0.01%
==========================================
Files 706 706
Lines 219137 219143 +6
Branches 41981 41995 +14
==========================================
+ Hits 196404 196432 +28
+ Misses 14614 14612 -2
+ Partials 8119 8099 -20
π New features to boost your workflow:
|
atlowChemi
added
the
author ready
JakobJingleheimer
approved these changes
Apr 22, 2026
MoLow
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62860 β Done loading data for nodejs/node/pull/62860 ----------------------------------- PR info ------------------------------------ Title test_runner: fix suite rerun edge case (#62860) Author Moshe Atlow <moshe@atlow.co.il> (@MoLow) Branch MoLow:fix-rerun-edge-case -> nodejs:main Labels author ready, needs-ci, test_runner Commits 1 - test_runner: fix suite rerun edge case Committers 1 - Moshe Atlow <moshe@atlow.co.il> PR-URL: https://github.com/nodejs/node/pull/62860 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62860 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> -------------------------------------------------------------------------------- βΉ This PR was created on Tue, 21 Apr 2026 06:16:50 GMT β Approvals: 2 β - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/62860#pullrequestreview-4145543640 β - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/62860#pullrequestreview-4157309955 β 7 GitHub CI job(s) cancelled: β - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/24707229122/job/72263125058) β - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/24707229122/job/72263125059) β - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/24707229123/job/72263125035) β - coverage-linux-without-intl: CANCELLED (https://github.com/nodejs/node/actions/runs/24707229130/job/72263125000) β - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/24707229129/job/72263124989) β - test-tarball-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/24707229148/job/72263560424) β - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/24707229163/job/72263125303) βΉ Last Full PR CI on 2026-04-21T07:51:20Z: https://ci.nodejs.org/job/node-test-pull-request/72810/ - Querying data for job/node-test-pull-request/72810/ β Build data downloaded β Last Jenkins CI successful -------------------------------------------------------------------------------- β Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/24820518687 |
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 633b963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.