fs: add throwIfNoEntry option to fs.lstat/fs.promises.lstat#63116
fs: add throwIfNoEntry option to fs.lstat/fs.promises.lstat#63116Renegade334 wants to merge 2 commits intonodejs:mainfrom
Conversation
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
|
Having an opt-out of synchronous throw makes perfect sense to allow a more performant path, but I don't think it applies for async API – I get the point of align the APIs, but if there are no use-cases for it, it's probably not worth adding |
I agreed at the time, but now that it's in (ie. |
|
There's precedence for this in #61178 |
honey, I broke the linter
200fb01 to
10413d6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63116 +/- ##
==========================================
+ Coverage 89.65% 89.69% +0.04%
==========================================
Files 712 712
Lines 220512 221271 +759
Branches 42289 42390 +101
==========================================
+ Hits 197690 198477 +787
+ Misses 14663 14650 -13
+ Partials 8159 8144 -15
🚀 New features to boost your workflow:
|
This is present on lstatSync but wasn't added to the other lstat functions in #61178, leaving the API asymmetrical.
Copies a couple of deduplications/simplifications back to the equivalent stat functions.
Refs: #61178