[canary-base] test: remove test-node-output-v8-warning#63469
Open
joyeecheung wants to merge 1 commit into
Open
[canary-base] test: remove test-node-output-v8-warning#63469joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
asm.js validation is deprecated and disabled by default in V8, so there's no longer a stable user-reachable trigger for `v8::Isolate::kMessageWarning`. Remove the test. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
nodejs-github-bot
added
needs-ci
targos
approved these changes
May 21, 2026
aduh95
approved these changes
May 21, 2026
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asm.js validation is deprecated and disabled by default in V8, so there's no longer a stable user-reachable trigger for
v8::Isolate::kMessageWarning. Remove the test.Refs: https://issues.chromium.org/issues/510487707
Refs: #24365
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184
Fixes: nodejs/node-v8#310