fix(a11y): add correct aria-label on ThemeToggle button
#756
avivkellerplaywright.yml
on: pull_request
Get Vercel Preview
8s
Playwright Tests
8m 14s
Annotations
10 errors and 1 notice
|
[firefox] › tests/e2e/general-behavior.spec.ts:72:5 › Node.js Website › Theme › should toggle between light/dark themes:
apps/site/tests/e2e/general-behavior.spec.ts#L76
3) [firefox] › tests/e2e/general-behavior.spec.ts:72:5 › Node.js Website › Theme › should toggle between light/dark themes
Error: Timed out 5000ms waiting for expect(locator).toBeVisible()
Locator: getByRole('button', { name: 'Switch to Light Mode' })
Expected: visible
Received: <element(s) not found>
Call log:
- Expect "toBeVisible" with timeout 5000ms
- waiting for getByRole('button', { name: 'Switch to Light Mode' })
74 | name: locators.themeToggleName,
75 | });
> 76 | await expect(themeToggle).toBeVisible();
| ^
77 |
78 | const initialTheme = await getTheme(page);
79 | const initialAriaLabel = await themeToggle.getAttribute('aria-label');
at /home/runner/work/nodejs.org/nodejs.org/apps/site/tests/e2e/general-behavior.spec.ts:76:33
|
|
[chromium] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation:
apps/site/tests/e2e/general-behavior.spec.ts#L99
2) [chromium] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.click: Test timeout of 30000ms exceeded.
Call log:
- waiting for getByRole('button', { name: 'Switch to Light Mode' })
97 | name: locators.themeToggleName,
98 | });
> 99 | await themeToggle.click();
| ^
100 | const selectedTheme = await getTheme(page);
101 |
102 | await page.reload();
at /home/runner/work/nodejs.org/nodejs.org/apps/site/tests/e2e/general-behavior.spec.ts:99:25
|
|
[chromium] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation:
apps/site/tests/e2e/general-behavior.spec.ts#L0
2) [chromium] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 30000ms exceeded.
|
|
[chromium] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation:
apps/site/tests/e2e/general-behavior.spec.ts#L99
2) [chromium] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.click: Test timeout of 30000ms exceeded.
Call log:
- waiting for getByRole('button', { name: 'Switch to Light Mode' })
97 | name: locators.themeToggleName,
98 | });
> 99 | await themeToggle.click();
| ^
100 | const selectedTheme = await getTheme(page);
101 |
102 | await page.reload();
at /home/runner/work/nodejs.org/nodejs.org/apps/site/tests/e2e/general-behavior.spec.ts:99:25
|
|
[chromium] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation:
apps/site/tests/e2e/general-behavior.spec.ts#L0
2) [chromium] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 30000ms exceeded.
|
|
[chromium] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation:
apps/site/tests/e2e/general-behavior.spec.ts#L99
2) [chromium] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation
Error: locator.click: Test timeout of 30000ms exceeded.
Call log:
- waiting for getByRole('button', { name: 'Switch to Light Mode' })
97 | name: locators.themeToggleName,
98 | });
> 99 | await themeToggle.click();
| ^
100 | const selectedTheme = await getTheme(page);
101 |
102 | await page.reload();
at /home/runner/work/nodejs.org/nodejs.org/apps/site/tests/e2e/general-behavior.spec.ts:99:25
|
|
[chromium] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation:
apps/site/tests/e2e/general-behavior.spec.ts#L0
2) [chromium] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation
Test timeout of 30000ms exceeded.
|
|
[chromium] › tests/e2e/general-behavior.spec.ts:72:5 › Node.js Website › Theme › should toggle between light/dark themes:
apps/site/tests/e2e/general-behavior.spec.ts#L76
1) [chromium] › tests/e2e/general-behavior.spec.ts:72:5 › Node.js Website › Theme › should toggle between light/dark themes
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toBeVisible()
Locator: getByRole('button', { name: 'Switch to Light Mode' })
Expected: visible
Received: <element(s) not found>
Call log:
- Expect "toBeVisible" with timeout 5000ms
- waiting for getByRole('button', { name: 'Switch to Light Mode' })
74 | name: locators.themeToggleName,
75 | });
> 76 | await expect(themeToggle).toBeVisible();
| ^
77 |
78 | const initialTheme = await getTheme(page);
79 | const initialAriaLabel = await themeToggle.getAttribute('aria-label');
at /home/runner/work/nodejs.org/nodejs.org/apps/site/tests/e2e/general-behavior.spec.ts:76:33
|
|
[chromium] › tests/e2e/general-behavior.spec.ts:72:5 › Node.js Website › Theme › should toggle between light/dark themes:
apps/site/tests/e2e/general-behavior.spec.ts#L76
1) [chromium] › tests/e2e/general-behavior.spec.ts:72:5 › Node.js Website › Theme › should toggle between light/dark themes
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toBeVisible()
Locator: getByRole('button', { name: 'Switch to Light Mode' })
Expected: visible
Received: <element(s) not found>
Call log:
- Expect "toBeVisible" with timeout 5000ms
- waiting for getByRole('button', { name: 'Switch to Light Mode' })
74 | name: locators.themeToggleName,
75 | });
> 76 | await expect(themeToggle).toBeVisible();
| ^
77 |
78 | const initialTheme = await getTheme(page);
79 | const initialAriaLabel = await themeToggle.getAttribute('aria-label');
at /home/runner/work/nodejs.org/nodejs.org/apps/site/tests/e2e/general-behavior.spec.ts:76:33
|
|
[chromium] › tests/e2e/general-behavior.spec.ts:72:5 › Node.js Website › Theme › should toggle between light/dark themes:
apps/site/tests/e2e/general-behavior.spec.ts#L76
1) [chromium] › tests/e2e/general-behavior.spec.ts:72:5 › Node.js Website › Theme › should toggle between light/dark themes
Error: Timed out 5000ms waiting for expect(locator).toBeVisible()
Locator: getByRole('button', { name: 'Switch to Light Mode' })
Expected: visible
Received: <element(s) not found>
Call log:
- Expect "toBeVisible" with timeout 5000ms
- waiting for getByRole('button', { name: 'Switch to Light Mode' })
74 | name: locators.themeToggleName,
75 | });
> 76 | await expect(themeToggle).toBeVisible();
| ^
77 |
78 | const initialTheme = await getTheme(page);
79 | const initialAriaLabel = await themeToggle.getAttribute('aria-label');
at /home/runner/work/nodejs.org/nodejs.org/apps/site/tests/e2e/general-behavior.spec.ts:76:33
|
|
🎭 Playwright Run Summary
6 failed
[chromium] › tests/e2e/general-behavior.spec.ts:72:5 › Node.js Website › Theme › should toggle between light/dark themes
[chromium] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation
[firefox] › tests/e2e/general-behavior.spec.ts:72:5 › Node.js Website › Theme › should toggle between light/dark themes
[firefox] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation
[webkit] › tests/e2e/general-behavior.spec.ts:72:5 › Node.js Website › Theme › should toggle between light/dark themes
[webkit] › tests/e2e/general-behavior.spec.ts:95:5 › Node.js Website › Theme › should persist theme across page navigation
12 passed (6.1m)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
playwright-report
Expired
|
15.3 MB |
sha256:bbdbf7a6fb86637ebd694534f1f579c7ddf4998fd851415ddb9ce87a3851d13d
|
|