refactor: review

Author: araujogui

apps/site/next-data/generators/supportersData.mjs

@@ -19,8 +19,10 @@ async function fetchOpenCollectiveData() {
       name,
       image,
       url: website,
-      // If profile starts with 'guest-', it's a non-existing account
-      profile: profile.includes('guest-') ? null : profile,
+      // If profile starts with the guest- prefix, it's a non-existing account
+      profile: profile.startsWith('https://opencollective.com/guest-')
+        ? undefined
+        : profile,
       source: 'opencollective',
     }));
 

apps/site/types/supporters.ts

@@ -2,7 +2,7 @@ export type Supporter<T extends string> = {
   name: string;
   image: string;
   url: string;
-  profile: string;
+  profile?: string;
   source: T;
 };